Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 10532207: Handling of scrollbar arrow size between for Aura-on-Windows (Closed)

Created:
8 years, 6 months ago by scottmg
Modified:
8 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Aura doesn't use scrollbar buttons. With https://bugs.webkit.org/show_bug.cgi?id=89264 we get webkit to delegate the size determination to WebThemeEngineImpl, and then we can retrieve it from the either native_theme_aura or native_theme_win. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142993

Patch Set 1 #

Patch Set 2 : generic part size getting #

Patch Set 3 : return size instead of int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webkit/glue/webthemeengine_impl_win.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webthemeengine_impl_win.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
Other side of https://bugs.webkit.org/show_bug.cgi?id=89264
8 years, 6 months ago (2012-06-18 20:29:28 UTC) #1
jamesr
lgtm
8 years, 6 months ago (2012-06-18 23:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10532207/5001
8 years, 6 months ago (2012-06-19 00:35:18 UTC) #3
commit-bot: I haz the power
Try job failure for 10532207-5001 (retry) (retry) on win_rel for step "chrome_frame_net_tests". It's a second ...
8 years, 6 months ago (2012-06-19 04:50:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10532207/5001
8 years, 6 months ago (2012-06-19 16:19:56 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 18:19:25 UTC) #6
Change committed as 142993

Powered by Google App Engine
This is Rietveld 408576698