Issue 10532174: Deprecate 'direct' parameter on webkit_support::CreateGraphicsContext3D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10532174: Deprecate 'direct' parameter on webkit_support::CreateGraphicsContext3D (Closed)

Created:
8 years, 6 months ago by jamesr

Modified:
8 years, 6 months ago

Reviewers:
nduca

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Deprecate 'direct' parameter on webkit_support::CreateGraphicsContext3D There is only one caller to this function (WebViewHost.cpp in the WebKit repo) and it always specifies the literal "true". Removing this parameter will let us remove a really nasty getter from WebView. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142549

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	webkit/support/webkit_support.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	webkit/support/webkit_support.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10532174/1

8 years, 6 months ago (2012-06-15 23:38:25 UTC) #3

Change committed as 142549

Expand Messages | Collapse Messages