Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 10532168: Allow empty strings to be written to the clipboard (Closed)

Created:
8 years, 6 months ago by dcheng
Modified:
8 years, 6 months ago
Reviewers:
tony, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Allow empty strings to be written to the clipboard BUG=109810 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142554

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix Aura #

Patch Set 3 : Err #

Patch Set 4 : Fix missing ; #

Patch Set 5 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -64 lines) Patch
M content/browser/web_contents/web_contents_drag_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 2 chunks +15 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 1 chunk +7 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_source_gtk.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 4 chunks +6 lines, -6 lines 0 comments Download
M content/common/drag_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/glue/webdropdata.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webdropdata.cc View 1 2 3 4 5 chunks +14 lines, -9 lines 0 comments Download
M webkit/glue/webdropdata_win.cc View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
8 years, 6 months ago (2012-06-15 20:56:53 UTC) #1
tony
http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc File webkit/glue/webdropdata.cc (right): http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc#newcode102 webkit/glue/webdropdata.cc:102: // TODO(dcheng): We need a way to distinguish between ...
8 years, 6 months ago (2012-06-15 21:09:23 UTC) #2
tony
LGTM
8 years, 6 months ago (2012-06-15 21:09:36 UTC) #3
dcheng
+jam for content approval. http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc File webkit/glue/webdropdata.cc (right): http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc#newcode102 webkit/glue/webdropdata.cc:102: // TODO(dcheng): We need a ...
8 years, 6 months ago (2012-06-15 21:15:43 UTC) #4
tony
On 2012/06/15 21:15:43, dcheng wrote: > +jam for content approval. > > http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc > File ...
8 years, 6 months ago (2012-06-15 21:22:31 UTC) #5
jam
lgtm http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc File webkit/glue/webdropdata.cc (right): http://codereview.chromium.org/10532168/diff/1/webkit/glue/webdropdata.cc#newcode102 webkit/glue/webdropdata.cc:102: // TODO(dcheng): We need a way to distinguish ...
8 years, 6 months ago (2012-06-15 22:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/10532168/7017
8 years, 6 months ago (2012-06-15 23:08:26 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-16 01:28:25 UTC) #8
Change committed as 142554

Powered by Google App Engine
This is Rietveld 408576698