webkit/glue/webclipboard_impl.cc - Issue 10532168: Allow empty strings to be written to the clipboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webclipboard_impl.cc

Issue 10532168: Allow empty strings to be written to the clipboard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment fix Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/glue/webclipboard_impl.cc

diff --git a/webkit/glue/webclipboard_impl.cc b/webkit/glue/webclipboard_impl.cc

index b782cd2d9fa7eceeb90aa77446f0a1187c981b3d..eb71a615f4a27b7acd5404747a658740029915af 100644

--- a/webkit/glue/webclipboard_impl.cc

+++ b/webkit/glue/webclipboard_impl.cc

@@ -235,8 +235,10 @@ void WebClipboardImpl::writeDataObject(const WebDragData& data) {

WebDropData data_object(data);

// TODO(dcheng): Properly support text/uri-list here.

- scw.WriteText(data_object.plain_text);

- scw.WriteHTML(data_object.text_html, "");

+ if (!data_object.text.is_null())

+ scw.WriteText(data_object.text.string());

+ if (!data_object.html.is_null())

+ scw.WriteHTML(data_object.html.string(), "");

// If there is no custom data, avoid calling WritePickledData. This ensures

// that ScopedClipboardWriterGlue's dtor remains a no-op if the page didn't

// modify the DataTransfer object, which is important to avoid stomping on

« no previous file with comments | « ui/base/clipboard/scoped_clipboard_writer.cc ('k') | webkit/glue/webdropdata.h » ('j') | no next file with comments »