Issue 3532. Report error if one unit included twice

Issue 3532. Report error if one unit included twice
http://code.google.com/p/dart/issues/detail?id=3532


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8562

[Brian Wilkerson, 2012-06-12 15:34:14]

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:627: String path =
sourceNode.getText();
I'm not sure this is correct. Don't we need to catch cases like

  #source('foo.dart');
  #source('../here/foo.dart');

(where 'here' is the directory containing the library file)? I think what we
really need here is

  path = lib.getSource().getSourceFor(sourceNode.getText()).getRelativePath();

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

[scheglov, 2012-06-12 18:17:51]

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:627: String path =
sourceNode.getText();
On 2012/06/12 15:34:14, Brian Wilkerson wrote:
> I'm not sure this is correct. Don't we need to catch cases like
> 
>   #source('foo.dart');
>   #source('../here/foo.dart');
> 
> (where 'here' is the directory containing the library file)? I think what we
> really need here is
> 
>   path = lib.getSource().getSourceFor(sourceNode.getText()).getRelativePath();

Done.

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/12 15:34:14, Brian Wilkerson wrote:
> nit: copyright year

Done.

[Brian Wilkerson, 2012-06-12 18:26:29]

LGTM

https://chromiumcodereview.appspot.com/10532100/diff/3001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/3001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:22:
UNIT_WAS_ALREADY_INCLUDED("Unit '%s' was already included");
nit: perhaps instead of "included" we should say "sourced"?

[scheglov, 2012-06-12 18:38:20]

https://chromiumcodereview.appspot.com/10532100/diff/3001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (right):

https://chromiumcodereview.appspot.com/10532100/diff/3001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:22:
UNIT_WAS_ALREADY_INCLUDED("Unit '%s' was already included");
On 2012/06/12 18:26:29, Brian Wilkerson wrote:
> nit: perhaps instead of "included" we should say "sourced"?

"sourced" sounds as slang for me.
I've used to it however.

Spec says in "12.3 Includes":
An include directive species a URI where a Dart compilation unit that should
be incorporated into the current library may be found.

So, it looks for me that best word from from spec would be "incorporated" :-)
Or "included" by the name (but not keyword) or directive.
Well, this is mess...