replace string16 with StringPiece16 in ConvertUTF16ToJavaString()

replace string16 with StringPiece16 in ConvertUTF16ToJavaString()


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141607

[joth, 2012-06-11 23:39:37]

thanks for picking this one up! couple more small tidy-ups while you're in
there..

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string.cc
File base/android/jni_string.cc (right):

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.cc:65: const base::StringPiece16& str) {
likewise as this fit when aligned with the open parenthesis, all params should
be moved to the OK3 indent-by-4 spaces format.
(and line 37 isn't quite right either for that style... one param per line....)

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string.h
File base/android/jni_string.h (right):

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.h:12: #include "base/string16.h"
I think this can be removed now?

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.h:32: JNIEnv* env, const base::StringPiece16& str);
nit: one param per line (see "OK3" in
http://www.chromium.org/developers/coding-style#TOC-Code-formatting)

(yep, line 24 should be fixed too)

[Wei James(wistoch), 2012-06-12 01:25:29]

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string.cc
File base/android/jni_string.cc (right):

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.cc:65: const base::StringPiece16& str) {
On 2012/06/11 23:39:38, joth wrote:
> likewise as this fit when aligned with the open parenthesis, all params should
> be moved to the OK3 indent-by-4 spaces format.
> (and line 37 isn't quite right either for that style... one param per
line....)

fixed. thanks

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string.h
File base/android/jni_string.h (right):

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.h:12: #include "base/string16.h"
On 2012/06/11 23:39:38, joth wrote:
> I think this can be removed now?

fixed. thanks

http://chromiumcodereview.appspot.com/10532081/diff/4/base/android/jni_string...
base/android/jni_string.h:32: JNIEnv* env, const base::StringPiece16& str);
On 2012/06/11 23:39:38, joth wrote:
> nit: one param per line (see "OK3" in
> http://www.chromium.org/developers/coding-style#TOC-Code-formatting)
> 
> (yep, line 24 should be fixed too)

fixed. thanks

[joth, 2012-06-12 01:31:14]

lgtm

[commit-bot: I haz the power, 2012-06-12 01:32:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10532081/7001

[Wei James(wistoch), 2012-06-12 01:32:27]

On 2012/06/12 01:31:14, joth wrote:
> lgtm

thanks for reviewing it. thanks

[commit-bot: I haz the power, 2012-06-12 03:25:45]

Change committed as 141607