Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2677)

Unified Diff: base/android/jni_string.cc

Issue 10532081: replace string16 with StringPiece16 in ConvertUTF16ToJavaString() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix coding style Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_string.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_string.cc
diff --git a/base/android/jni_string.cc b/base/android/jni_string.cc
index d0ffeecc418fa410095a56a6dbc879a5ba06da20..c8a90ca9e1012c9d97ac0e822350081c6937fd35 100644
--- a/base/android/jni_string.cc
+++ b/base/android/jni_string.cc
@@ -11,7 +11,8 @@
namespace {
// Internal version that does not use a scoped local pointer.
-jstring ConvertUTF16ToJavaStringImpl(JNIEnv* env, const string16& str) {
+jstring ConvertUTF16ToJavaStringImpl(JNIEnv* env,
+ const base::StringPiece16& str) {
jstring result = env->NewString(str.data(), str.length());
base::android::CheckException(env);
return result;
@@ -33,7 +34,8 @@ std::string ConvertJavaStringToUTF8(const JavaRef<jstring>& str) {
}
ScopedJavaLocalRef<jstring> ConvertUTF8ToJavaString(
- JNIEnv* env, const base::StringPiece& str) {
+ JNIEnv* env,
+ const base::StringPiece& str) {
// JNI's NewStringUTF expects "modified" UTF8 so instead create the string
// via our own UTF16 conversion utility.
// Further, Dalvik requires the string passed into NewStringUTF() to come from
@@ -60,9 +62,9 @@ string16 ConvertJavaStringToUTF16(const JavaRef<jstring>& str) {
return ConvertJavaStringToUTF16(AttachCurrentThread(), str.obj());
}
-// TODO(joth): change this to accept const StringPiece16&.
-ScopedJavaLocalRef<jstring> ConvertUTF16ToJavaString(JNIEnv* env,
- const string16& str) {
+ScopedJavaLocalRef<jstring> ConvertUTF16ToJavaString(
+ JNIEnv* env,
+ const base::StringPiece16& str) {
return ScopedJavaLocalRef<jstring>(env,
ConvertUTF16ToJavaStringImpl(env, str));
}
« no previous file with comments | « base/android/jni_string.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698