Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10532067: Move CapturingNetLog over to net_test_support from net. (Closed)

Created:
8 years, 6 months ago by mmenke
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move CapturingNetLog over to net_test_support from net. R=eroman@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141265

Patch Set 1 #

Patch Set 2 : Oops #

Total comments: 4

Patch Set 3 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M net/base/capturing_net_log.h View 1 2 3 chunks +5 lines, -8 lines 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mmenke
I have the CL that gets rid of max entries pretty much done, but want ...
8 years, 6 months ago (2012-06-08 14:55:12 UTC) #1
eroman
lgtm http://codereview.chromium.org/10532067/diff/1003/net/base/capturing_net_log.h File net/base/capturing_net_log.h (right): http://codereview.chromium.org/10532067/diff/1003/net/base/capturing_net_log.h#newcode28 net/base/capturing_net_log.h:28: // bounded buffer. CapturingNetLogs should only be used ...
8 years, 6 months ago (2012-06-08 18:18:23 UTC) #2
mmenke
http://codereview.chromium.org/10532067/diff/1003/net/base/capturing_net_log.h File net/base/capturing_net_log.h (right): http://codereview.chromium.org/10532067/diff/1003/net/base/capturing_net_log.h#newcode28 net/base/capturing_net_log.h:28: // bounded buffer. CapturingNetLogs should only be used in ...
8 years, 6 months ago (2012-06-08 18:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10532067/6002
8 years, 6 months ago (2012-06-08 18:27:50 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 19:58:46 UTC) #5
Change committed as 141265

Powered by Google App Engine
This is Rietveld 408576698