Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: net/base/capturing_net_log.h

Issue 10532067: Move CapturingNetLog over to net_test_support from net. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/net.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/capturing_net_log.h
===================================================================
--- net/base/capturing_net_log.h (revision 141205)
+++ net/base/capturing_net_log.h (working copy)
@@ -16,7 +16,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "base/time.h"
-#include "net/base/net_export.h"
#include "net/base/net_log.h"
namespace base {
@@ -26,13 +25,11 @@
namespace net {
// CapturingNetLog is an implementation of NetLog that saves messages to a
-// bounded buffer. CapturingNetLogs should only be used in unit tests, never
-// in production code.
-// TODO(mmenke): Move CapturingNetLog to net_unittests project, once the CL
-// to remove the use of it in the Jingle unit tests has landed.
-class NET_EXPORT CapturingNetLog : public NetLog {
+// bounded buffer. It is intended for testing only, and is part of the
+// net_test_support project.
+class CapturingNetLog : public NetLog {
public:
- struct NET_EXPORT_PRIVATE CapturedEntry {
+ struct CapturedEntry {
CapturedEntry(EventType type,
const base::TimeTicks& time,
Source source,
@@ -116,7 +113,7 @@
//
// CapturingBoundNetLog can easily be converted to a BoundNetLog using the
// bound() method.
-class NET_EXPORT_PRIVATE CapturingBoundNetLog {
+class CapturingBoundNetLog {
public:
explicit CapturingBoundNetLog(size_t max_num_entries);
« no previous file with comments | « no previous file | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698