Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2728)

Unified Diff: chrome/browser/resources/gesture_config.html

Issue 10532005: Initial check-in of gesture config WebUI. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Addressed lates review comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gesture_config.html
diff --git a/chrome/browser/resources/gesture_config.html b/chrome/browser/resources/gesture_config.html
new file mode 100644
index 0000000000000000000000000000000000000000..a9cb3b3c80efe28656407f161d0014f020f0802a
--- /dev/null
+++ b/chrome/browser/resources/gesture_config.html
@@ -0,0 +1,27 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+ <meta charset="utf-8">
+ <title>Gesture Preferences</title>
James Hawkins 2012/06/12 15:48:14 Title needs to be internationalized.
Kevin Greer 2012/06/12 18:01:53 This is an unsupported feature which does not need
+ <link rel="stylesheet" href="gesture_config.css">
+ <script src="gesture_config.js"></script>
+</head>
+<body>
+<h2>Gesture Preferences</h2>
James Hawkins 2012/06/12 15:48:14 Internationalized.
Kevin Greer 2012/06/12 18:01:53 Not needed. On 2012/06/12 15:48:14, James Hawkins
+<hr/>
James Hawkins 2012/06/12 15:48:14 No trailing slash on self-closing blocks.
Kevin Greer 2012/06/12 18:01:53 Removed. On 2012/06/12 15:48:14, James Hawkins wro
+<form>
+ <div id="gesture-form"></div>
+
James Hawkins 2012/06/12 15:48:14 nit: Remove blank line.
Kevin Greer 2012/06/12 18:01:53 Done.
+ <div class="buttons-pane">
+ <button id="resetButton">Reset</button>
James Hawkins 2012/06/12 15:48:14 Internationalized.
Kevin Greer 2012/06/12 18:01:53 Not needed. On 2012/06/12 15:48:14, James Hawkins
+ </div>
+</form>
+<div hidden>
+ <div id="gesture-form-row" class="row">
+ <label class="row-label"></label>
James Hawkins 2012/06/12 15:48:14 nit: <label> needs a for= attribute specified.
Kevin Greer 2012/06/12 18:01:53 Done (in gesture_config.js).
+ <input class="row-input" type="number" size="20"/>
James Hawkins 2012/06/12 15:48:14 No trailing slash on self-closing blocks: <input
Kevin Greer 2012/06/12 18:01:53 Removed. On 2012/06/12 15:48:14, James Hawkins wro
+ <div class="row-units"></div>
+ </div>
+</div>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698