chrome/browser/resources/gesture_config.html - Issue 10532005: Initial check-in of gesture config WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/gesture_config.html

Issue 10532005: Initial check-in of gesture config WebUI. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Addressed lates review comments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/gesture_config.css ('K') | « chrome/browser/resources/gesture_config.css ('k') | chrome/browser/resources/gesture_config.js » ('j') | chrome/browser/resources/gesture_config.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <meta charset="utf-8">

	5 <title>Gesture Preferences</title>
	James Hawkins 2012/06/12 15:48:14 Title needs to be internationalized. Title needs to be internationalized. Kevin Greer 2012/06/12 18:01:53 This is an unsupported feature which does not need This is an unsupported feature which does not need internationalization. On 2012/06/12 15:48:14, James Hawkins wrote: Show quoted text > Title needs to be internationalized.
	6 <link rel="stylesheet" href="gesture_config.css">

	7 <script src="gesture_config.js"></script>

	8 </head>

	9 <body>

	10 <h2>Gesture Preferences</h2>
	James Hawkins 2012/06/12 15:48:14 Internationalized. Internationalized. Kevin Greer 2012/06/12 18:01:53 Not needed. On 2012/06/12 15:48:14, James Hawkins Not needed. On 2012/06/12 15:48:14, James Hawkins wrote: Show quoted text > Internationalized.
	11 <hr/>
	James Hawkins 2012/06/12 15:48:14 No trailing slash on self-closing blocks. No trailing slash on self-closing blocks. Kevin Greer 2012/06/12 18:01:53 Removed. On 2012/06/12 15:48:14, James Hawkins wro Removed. On 2012/06/12 15:48:14, James Hawkins wrote: Show quoted text > No trailing slash on self-closing blocks.
	12 <form>

	13 <div id="gesture-form"></div>

	14
	James Hawkins 2012/06/12 15:48:14 nit: Remove blank line. nit: Remove blank line. Kevin Greer 2012/06/12 18:01:53 Done. Show quoted text On 2012/06/12 15:48:14, James Hawkins wrote: > nit: Remove blank line. Done.
	15 <div class="buttons-pane">

	16 <button id="resetButton">Reset</button>
	James Hawkins 2012/06/12 15:48:14 Internationalized. Internationalized. Kevin Greer 2012/06/12 18:01:53 Not needed. On 2012/06/12 15:48:14, James Hawkins Not needed. On 2012/06/12 15:48:14, James Hawkins wrote: Show quoted text > Internationalized.
	17 </div>

	18 </form>

	19 <div hidden>

	20 <div id="gesture-form-row" class="row">

	21 <label class="row-label"></label>
	James Hawkins 2012/06/12 15:48:14 nit: <label> needs a for= attribute specified. nit: <label> needs a for= attribute specified. Kevin Greer 2012/06/12 18:01:53 Done (in gesture_config.js). Show quoted text On 2012/06/12 15:48:14, James Hawkins wrote: > nit: <label> needs a for= attribute specified. Done (in gesture_config.js).
	22 <input class="row-input" type="number" size="20"/>
	James Hawkins 2012/06/12 15:48:14 No trailing slash on self-closing blocks: <input No trailing slash on self-closing blocks: <input ...> Kevin Greer 2012/06/12 18:01:53 Removed. On 2012/06/12 15:48:14, James Hawkins wro Removed. On 2012/06/12 15:48:14, James Hawkins wrote: Show quoted text > No trailing slash on self-closing blocks: > > <input ...>
	23 <div class="row-units"></div>

	24 </div>

	25 </div>

	26 </body>

	27 </html>

OLD	NEW