lib/dom/scripts/idlnode.py - Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/idlnode.py

Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/idlnode.py

diff --git a/lib/dom/scripts/idlnode.py b/lib/dom/scripts/idlnode.py

index cc4108ca73fcc9a17e9b908a5eb49b16ce9d0bcf..83a97d293d0e8f7ec16b632edf62553ca5e71c46 100755

--- a/lib/dom/scripts/idlnode.py

+++ b/lib/dom/scripts/idlnode.py

@@ -459,9 +459,7 @@ class IDLArgument(IDLNode):

IDLNode.__init__(self, ast)

self.type = self._convert_first(ast, 'Type', IDLType)

self._convert_ext_attrs(ast)

- # WebKit and Web IDL differ in how Optional is declared:

- self.is_optional = self._has(ast, 'Optional') \

- or ('Optional' in self.ext_attrs)

+ self.is_optional = 'Optional' in self.ext_attrs

def __repr__(self):

return '<IDLArgument(type = %s, id = %s)>' % (self.type, self.id)

« no previous file with comments | « lib/dom/scripts/databasebuilder.py ('k') | lib/dom/scripts/idlrenderer.py » ('j') | no next file with comments »