lib/dom/scripts/databasebuilder.py - Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/databasebuilder.py

Issue 10521002: Use WebKit IDL syntax for declaring optional parameters in dart.idl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/databasebuilder.py

diff --git a/lib/dom/scripts/databasebuilder.py b/lib/dom/scripts/databasebuilder.py

index 0dc2ce18bd074d52b078a3398f585e84ee1343b0..9ad31bf0783f4c0e29c4940d1717f78a9868b426 100755

--- a/lib/dom/scripts/databasebuilder.py

+++ b/lib/dom/scripts/databasebuilder.py

@@ -129,15 +129,15 @@ class DatabaseBuilder(object):

in_optional_whitelist = (interface.id, op.id, argument.id) in optional_argument_whitelist

if in_optional_whitelist or set(['Optional', 'Callback']).issubset(argument.ext_attrs.keys()):

argument.is_optional = True

+ argument.ext_attrs['Optional'] = None

argument.ext_attrs['RequiredCppParameter'] = None

continue

- if argument.is_optional:

- if 'Optional' in argument.ext_attrs:

- optional_value = argument.ext_attrs['Optional']

- if optional_value:

- argument.is_optional = False

- del argument.ext_attrs['Optional']

+ if 'Optional' in argument.ext_attrs:

+ optional_value = argument.ext_attrs['Optional']

+ if optional_value:

+ argument.is_optional = False

+ del argument.ext_attrs['Optional']

# split operations with optional args into multiple operations

new_ops = []

« no previous file with comments | « lib/dom/idl/dart/dart.idl ('k') | lib/dom/scripts/idlnode.py » ('j') | no next file with comments »