chrome/browser/ui/views/location_bar/star_view.cc - Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view.cc

Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge to LKGR Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/star_view.h ('k') | chrome/browser/ui/views/location_bar/touchable_location_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/star_view.cc

diff --git a/chrome/browser/ui/views/location_bar/star_view.cc b/chrome/browser/ui/views/location_bar/star_view.cc

index 1dda0e405d97bc2a03c48936c6f877ece15f4fc2..b949ab3358217bb9a9b63d7d3408e8e2ab1ad71f 100644

--- a/chrome/browser/ui/views/location_bar/star_view.cc

+++ b/chrome/browser/ui/views/location_bar/star_view.cc

@@ -21,6 +21,7 @@ StarView::StarView(CommandUpdater* command_updater)

set_id(VIEW_ID_STAR_BUTTON);

SetToggled(false);

set_accessibility_focusable(true);

+ TouchableLocationBarView::Init(this);

}

StarView::~StarView() {

@@ -33,6 +34,10 @@ void StarView::SetToggled(bool on) {

on ? IDR_STAR_LIT : IDR_STAR));

}

+int StarView::GetBuiltInHorizontalPadding() const {

+ return GetBuiltInHorizontalPaddingImpl();

void StarView::GetAccessibleState(ui::AccessibleViewState* state) {

state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_STAR);

state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;