chrome/browser/ui/views/location_bar/star_view.h - Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 10519008: Enlarge size of touch target for several location bar buttons without affecting visual layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pure merge to LKGR Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/star_view.h

diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h

index 2a745ac1b7285e92e0616db6a0a852317e2de459..8d011d3808c9771bbd19451a2aedb98cb36f79dd 100644

--- a/chrome/browser/ui/views/location_bar/star_view.h

+++ b/chrome/browser/ui/views/location_bar/star_view.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_STAR_VIEW_H_

#pragma once

+#include "chrome/browser/ui/views/location_bar/touchable_location_bar_view.h"

#include "ui/views/controls/image_view.h"

class CommandUpdater;

@@ -15,7 +16,9 @@ class KeyEvent;

class MouseEvent;

}

-class StarView : public views::ImageView {

+class StarView

+ : public views::ImageView,

+ public TouchableLocationBarView {

public:

explicit StarView(CommandUpdater* command_updater);

virtual ~StarView();

@@ -23,6 +26,9 @@ class StarView : public views::ImageView {

// Toggles the star on or off.

void SetToggled(bool on);

+ // TouchableLocationBarView.

+ virtual int GetBuiltInHorizontalPadding() const OVERRIDE;

private:

// views::ImageView overrides:

virtual void GetAccessibleState(ui::AccessibleViewState* state) OVERRIDE;