Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10515007: Tighten up DEPS checking to enforce that embedders of content only include public test headers. (Closed)

Created:
8 years, 6 months ago by jam
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jochen+watch-content_chromium.org, grt+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, robertshield
Visibility:
Public.

Description

Tighten up DEPS checking to enforce that embedders of content only include public test headers. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140296

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/DEPS View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/DEPS View 1 chunk +4 lines, -11 lines 4 comments Download
M chrome_frame/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
8 years, 6 months ago (2012-06-04 15:15:54 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 6 months ago (2012-06-04 15:49:02 UTC) #2
tfarina
http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS File chrome/test/DEPS (right): http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS#newcode13 chrome/test/DEPS:13: # and content/test. http://crbug.com/98716 nit: and content/public/test?
8 years, 6 months ago (2012-06-04 15:52:14 UTC) #3
jam
http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS File chrome/test/DEPS (right): http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS#newcode13 chrome/test/DEPS:13: # and content/test. http://crbug.com/98716 On 2012/06/04 15:52:15, tfarina wrote: ...
8 years, 6 months ago (2012-06-04 15:56:09 UTC) #4
tfarina
http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS File chrome/test/DEPS (right): http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS#newcode13 chrome/test/DEPS:13: # and content/test. http://crbug.com/98716 On 2012/06/04 15:56:09, John Abd-El-Malek ...
8 years, 6 months ago (2012-06-04 15:57:55 UTC) #5
jam
8 years, 6 months ago (2012-06-04 16:26:50 UTC) #6 
http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS
File chrome/test/DEPS (right):

http://codereview.chromium.org/10515007/diff/1/chrome/test/DEPS#newcode13
chrome/test/DEPS:13: # and content/test. http://crbug.com/98716
On 2012/06/04 15:57:55, tfarina wrote:
> On 2012/06/04 15:56:09, John Abd-El-Malek wrote:
> > On 2012/06/04 15:52:15, tfarina wrote:
> > > nit: and content/public/test?
> > 
> > line 10 already has content/public
> 
> so just remove that part of the comment, since it isn't valid anymore?

http://codereview.chromium.org/10521005

Powered by Google App Engine
This is Rietveld 408576698