Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: chrome/test/DEPS

Issue 10515007: Tighten up DEPS checking to enforce that embedders of content only include public test headers. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/DEPS ('k') | chrome_frame/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/DEPS
===================================================================
--- chrome/test/DEPS (revision 140288)
+++ chrome/test/DEPS (working copy)
@@ -2,23 +2,16 @@
# The test directory can do whatever it wants in chrome.
"+chrome",
- # Tests under chrome/ shouldn't need to access the internals of
- # content/ and as such are allowed only content/public and
- # content/test (which is the "public" directory for tests depending
- # on content/). If you find yourself wanting to write such a test,
- # or a test that depends primarily on content, think about whether
- # the test belongs under content/, or should be split up into a test
+ # Tests under chrome/ shouldn't need to access the internals of content/ and
+ # as such are allowed only content/public. If you find yourself wanting to
+ # write such a test, or a test that depends primarily on content, think about
+ # whether the test belongs under content/, or should be split up into a test
# within content/ and a test within chrome/.
- "-content",
"+content/public",
- "+content/test",
# TODO(joi): Need to remove all of these and use only content/public
# and content/test. http://crbug.com/98716
tfarina 2012/06/04 15:52:15 nit: and content/public/test?
jam 2012/06/04 15:56:09 line 10 already has content/public
tfarina 2012/06/04 15:57:55 so just remove that part of the comment, since it
jam 2012/06/04 16:26:50 http://codereview.chromium.org/10521005
# DO NOT ADD ANY MORE ITEMS TO THE LIST BELOW!
- "+content/browser/net/url_request_mock_http_job.h",
- "+content/browser/net/url_request_slow_http_job.h",
- "+content/browser/trace_controller.h",
"+content/common/debug_flags.h",
"+content/common/injection_test_dll.h",
"+content/renderer/mock_content_renderer_client.h",
« no previous file with comments | « chrome/DEPS ('k') | chrome_frame/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698