dartdoc: --omit-generation-time flag to exclude generation time from output

dartdoc: --omit-generation-time flag to exclude generation time from output

BUG= http://dartbug.com/3374
TEST=run dartdoc with the new flag '--omit-generation-time' and notice the lack of timestamp in the output

Committed: https://code.google.com/p/dart/source/detail?r=8265

[kevmoo-old, 2012-06-04 16:47:41]

Addressing dartbug.com/3374

Also a tiny tweak to the footer logic.
 - All child items are divs.
 - if no footer text is provided, the empty div is not generated

[Jennifer Messerly, 2012-06-04 17:46:40]

On 2012/06/04 16:47:41, kevmoo wrote:
> Addressing dartbug.com/3374
> 
> Also a tiny tweak to the footer logic.
>  - All child items are divs.
>  - if no footer text is provided, the empty div is not generated

Looks good to me. Thanks for the patch!

[Jennifer Messerly, 2012-06-04 17:47:01]

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:58: bool includeSource;
This comment is on the original code, but bools should initialized to false and
then they don't need to be tested as != null.

(That said, it's nice that you were consistent with the existing style :) )

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:62: bool omitGenerationTime;
I almost wonder if this should be showGenerationTime and default to off. It
seems like this could be a feature of apidoc if we only want it for
api.dartlang.org

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:121: if (omitGenerationTime != null)
dartdoc.omitGenerationTime = omitGenerationTime;
We generally try to keep code at 80 cols. I'm not a huge fan of it personally,
but some people are pretty attached to it so we try to keep to that style in the
codebase.

[kevmoo-old, 2012-06-04 17:51:40]

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.dart
File lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:58: bool includeSource;
Oh I thought about that...but I kept w/ the existing style.

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:62: bool omitGenerationTime;
Easy to change this to a positive value, that defaults to true.

The fact that my code checks for a double-negative (!omits) bothered me.

https://chromiumcodereview.appspot.com/10513007/diff/1/lib/dartdoc/dartdoc.da...
lib/dartdoc/dartdoc.dart:121: if (omitGenerationTime != null)
dartdoc.omitGenerationTime = omitGenerationTime;
Understood. Will fix.

[kevmoo-old, 2012-06-04 18:25:03]

Fixed issue regarding line length.

I left everything else to keep existing behavior.

Perhaps after we look at using args (http://dartbug.com/3384) it would make
sense to ponder changing defaults

[Jennifer Messerly, 2012-06-04 19:14:59]

On 2012/06/04 18:25:03, kevmoo wrote:
> Fixed issue regarding line length.
> 
> I left everything else to keep existing behavior.
> 
> Perhaps after we look at using args (http://dartbug.com/3384) it would make
> sense to ponder changing defaults

LGTM