Tighten up DEPS some more. NaCl/service process code are including internal content files. Fix the …

Tighten up DEPS some more. NaCl/service process code are including internal content files. Fix the instances other sandbox stuff, which I'll do in a followup.

BUG=98716
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140346

[brettw, 2012-06-04 19:28:48]

lgtm

[loislo, 2012-06-05 08:58:59]

On 2012/06/04 19:28:48, brettw wrote:
> lgtm

after bisecting I found that this patch broke frame_rate_test on Linux perf bot.
the typical output is:

[ RUN      ] FrameRateCompositingTest.blank/1
../../chrome/test/automation/proxy_launcher.cc:108: Failure
Value of: app_launched
  Actual: 5
Expected: AUTOMATION_SUCCESS
Which is: 0
Error while awaiting automation ping from browser process
../../chrome/test/ui/ui_test.cc:127: Failure
Value of: launcher_->InitializeConnection(DefaultLaunchState(),
wait_for_initial_loads_)
  Actual: false
Expected: true
[13298:13298:0605/125224:423537994763:ERROR:automation_proxy.cc(378)]
Disconnecting channel after error!
../../chrome/test/automation/proxy_launcher.cc:234: Failure
Value of: automation()->GetBrowserWindowCount(&window_count)
  Actual: false
Expected: true
[13298:13298:0605/125224:423537994886:ERROR:automation_proxy.cc(365)] Automation
channel has been closed; dropping message!
../../chrome/test/automation/proxy_launcher.cc:255: Failure
Value of: browser_proxy.get()
  Actual: false
Expected: true
../../chrome/test/automation/proxy_launcher.cc:281: Failure
Value of: WaitForBrowserProcessToQuit( TestTimeouts::action_max_timeout_ms(),
&exit_code)
  Actual: false
Expected: true
../../chrome/test/automation/proxy_launcher.cc:282: Failure
Value of: exit_code
  Actual: -1
Expected: 0
[  FAILED  ] FrameRateCompositingTest.blank/1, where GetParam() = 3 (369 ms)





http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/bui...

[jam, 2012-06-05 16:01:32]

are you sure? I'd be very surprised if this change broke anything. As you see,
it's moving files around.

The latest run just passed btw, so it seems flaky?
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/bui...

On 2012/06/05 08:58:59, loislo wrote:
> On 2012/06/04 19:28:48, brettw wrote:
> > lgtm
> 
> after bisecting I found that this patch broke frame_rate_test on Linux perf
bot.
> the typical output is:
> 
> [ RUN      ] FrameRateCompositingTest.blank/1
> ../../chrome/test/automation/proxy_launcher.cc:108: Failure
> Value of: app_launched
>   Actual: 5
> Expected: AUTOMATION_SUCCESS
> Which is: 0
> Error while awaiting automation ping from browser process
> ../../chrome/test/ui/ui_test.cc:127: Failure
> Value of: launcher_->InitializeConnection(DefaultLaunchState(),
> wait_for_initial_loads_)
>   Actual: false
> Expected: true
> [13298:13298:0605/125224:423537994763:ERROR:automation_proxy.cc(378)]
> Disconnecting channel after error!
> ../../chrome/test/automation/proxy_launcher.cc:234: Failure
> Value of: automation()->GetBrowserWindowCount(&window_count)
>   Actual: false
> Expected: true
> [13298:13298:0605/125224:423537994886:ERROR:automation_proxy.cc(365)]
Automation
> channel has been closed; dropping message!
> ../../chrome/test/automation/proxy_launcher.cc:255: Failure
> Value of: browser_proxy.get()
>   Actual: false
> Expected: true
> ../../chrome/test/automation/proxy_launcher.cc:281: Failure
> Value of: WaitForBrowserProcessToQuit( TestTimeouts::action_max_timeout_ms(),
> &exit_code)
>   Actual: false
> Expected: true
> ../../chrome/test/automation/proxy_launcher.cc:282: Failure
> Value of: exit_code
>   Actual: -1
> Expected: 0
> [  FAILED  ] FrameRateCompositingTest.blank/1, where GetParam() = 3 (369 ms)
> 
> 
> 
> 
> 
>
http://build.chromium.org/p/chromium.perf/builders/Linux%2520Perf%2520%25282%...