Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 10512008: Remove some unused code that fails to compile with -Wundef (Closed)

Created:
8 years, 6 months ago by Mark Seaborn
Modified:
8 years, 6 months ago
Reviewers:
bsy
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove some unused code that fails to compile with -Wundef This code contains "#if DEBUG" where DEBUG is undefined, which is rejected with gcc's -Wundef option. Since the code is unused it makes more sense to remove it than try to fix it. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2787 TEST=build Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1432 lines) Patch
M src/trusted/service_runtime/build.scons View 2 chunks +0 lines, -47 lines 0 comments Download
D src/trusted/service_runtime/fs/fs.h View 1 chunk +0 lines, -207 lines 0 comments Download
D src/trusted/service_runtime/fs/obj_proxy.h View 1 chunk +0 lines, -133 lines 0 comments Download
D src/trusted/service_runtime/fs/obj_proxy.c View 1 chunk +0 lines, -370 lines 0 comments Download
D src/trusted/service_runtime/fs/obj_proxy_test.c View 1 chunk +0 lines, -515 lines 0 comments Download
D src/trusted/service_runtime/fs/xdr.h View 1 chunk +0 lines, -89 lines 0 comments Download
D src/trusted/service_runtime/fs/xdr.c View 1 chunk +0 lines, -54 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years, 6 months ago (2012-06-04 17:05:39 UTC) #1
bsy
8 years, 6 months ago (2012-06-04 22:40:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698