Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10511007: Make HBreak and HContinue not extend HGoto. They now extend HJump which is independent of HGoto. To… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index 4c944d651fcf9b1a3b81feedcdea3b2bece48ab8..64683fcb1c306b68f0b528d42a312aef173c2fbd 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -893,7 +893,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
void emitAssignment(String destination, String source) {
- if (isGeneratingExpression()) {
+ if (isGeneratingExpression()) {
addExpressionSeparator();
} else {
addIndentation();
@@ -1238,9 +1238,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
bool isEmptyElse(HBasicBlock start, HBasicBlock end) {
if (start !== end) return false;
- if (start.last is !HGoto
- || start.last is HBreak
- || start.last is HContinue) {
+ if (start.last is !HGoto) {
return false;
ngeoffray 2012/06/06 11:05:29 one line?
Lasse Reichstein Nielsen 2012/06/06 13:04:07 NEVER! Ahem. I'd actually rather combine it with
}
for (HInstruction instruction = start.first;
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698