Make HBreak and HContinue not extend HGoto. They now extend HJump which is independent of HGoto. To…

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 875 matching lines @@
     }
     // Flow based traversal.
     if (node.isLoopHeader() &&
         node.loopInformation.loopBlockInformation !== currentBlockInformation) {
       beginLoop(node);
     }
     iterateBasicBlock(node);
   }
 
   void emitAssignment(String destination, String source) {
-    if (isGeneratingExpression()) { 
+    if (isGeneratingExpression()) {
       addExpressionSeparator();
     } else {
       addIndentation();
     }
     declareVariable(destination);
     buffer.add(' = $source');
     if (!isGeneratingExpression()) {
       buffer.add(';\n');
     }
   }
@@ skipping 324 matching lines @@
 
   visitTry(HTry node) {
     // We should never get here. Try/catch/finally is always handled using block
     // information in [visitTryInfo], or not at all, in the case of the bailout
     // generator.
     compiler.internalError('visitTry should not be called', instruction: node);
   }
 
   bool isEmptyElse(HBasicBlock start, HBasicBlock end) {
     if (start !== end) return false;
-    if (start.last is !HGoto
-        || start.last is HBreak
-        || start.last is HContinue) {
+    if (start.last is !HGoto) {
       return false;

[ngeoffray, 2012/06/06 11:05:29]

one line?

[Lasse Reichstein Nielsen, 2012/06/06 13:04:07]

NEVER!
Ahem.

I'd actually rather combine it with the test above, and keep the block. 
I don't like hiding early returns at the end of innocuously looking lines.

     }
     for (HInstruction instruction = start.first;
          instruction != start.last;
          instruction = instruction.next) {
       // Instructions generated at use site are okay because they do
       // not generate code in this else block.
       if (!isGenerateAtUseSite(instruction)) return false;
     }
     CopyHandler handler = variableNames.getCopyHandler(start);
     if (handler == null || handler.isEmpty()) return true;
@@ skipping 1262 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }