Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 10505006: Add files to unit_tests.isolate and browser_tests.isolate. (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews, csharp, MAD, motek., tayarani_google.com
Visibility:
Public.

Description

Add files to unit_tests.isolate and browser_tests.isolate. R=thakis@chromium.org BUG=98636 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140220

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -6 lines) Patch
M chrome/browser_tests.isolate View 2 chunks +572 lines, -6 lines 5 comments Download
M chrome/unit_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
Add a few other files to the dependencies. browser_tests pulls a lot of python_26 files ...
8 years, 6 months ago (2012-06-02 02:12:33 UTC) #1
Nico
lgtm stamp https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate#newcode23 chrome/browser_tests.isolate:23: '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX)', This file doesn't exist on mac. ...
8 years, 6 months ago (2012-06-02 02:17:01 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate#newcode23 chrome/browser_tests.isolate:23: '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX)', On 2012/06/02 02:17:02, Nico wrote: > This file ...
8 years, 6 months ago (2012-06-03 00:51:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10505006/1
8 years, 6 months ago (2012-06-03 00:51:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10505006/1
8 years, 6 months ago (2012-06-03 00:52:23 UTC) #5
Nico
https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://chromiumcodereview.appspot.com/10505006/diff/1/chrome/browser_tests.isolate#newcode23 chrome/browser_tests.isolate:23: '<(PRODUCT_DIR)/chrome<(EXECUTABLE_SUFFIX)', On 2012/06/03 00:51:49, Marc-Antoine Ruel wrote: > On ...
8 years, 6 months ago (2012-06-03 00:52:42 UTC) #6
commit-bot: I haz the power
Change committed as 140220
8 years, 6 months ago (2012-06-03 03:19:29 UTC) #7
rniwa-cr
It could be that this CL broke gclient sync on Windows: http://build.chromium.org/p/chromium/buildstatus?builder=Win&number=11422 http://build.chromium.org/p/chromium/buildstatus?builder=Win%20Builder&number=31466 http://build.chromium.org/p/chromium/buildstatus?builder=Win%20Builder%202010%20%28dbg%29&number=23782 http://build.chromium.org/p/chromium/buildstatus?builder=Win%20Builder%20%28dbg%29&number=32750 ...
8 years, 6 months ago (2012-06-03 05:00:06 UTC) #8
rniwa-cr
8 years, 6 months ago (2012-06-03 05:24:09 UTC) #9
Reverted the patch in
http://src.chromium.org/viewvc/chrome?view=rev&revision=140221 since clobbering
the bot didn't fix the problem.

Powered by Google App Engine
This is Rietveld 408576698