Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 10503006: fix NTP after another CSS flexbox property rename (Closed)

Created:
8 years, 6 months ago by Evan Stade
Modified:
8 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

fix NTP after another CSS flexbox property rename BUG=130911 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
8 years, 6 months ago (2012-06-02 06:07:34 UTC) #1
Dan Beam
I think it might be better to go back to old flex box until the ...
8 years, 6 months ago (2012-06-04 16:50:53 UTC) #2
Dan Beam
8 years, 6 months ago (2012-06-04 17:53:24 UTC) #3
tony
Using old flex box for this (ordering and alignment) is fine. You're not actually flexing ...
8 years, 6 months ago (2012-06-04 18:20:05 UTC) #4
Dan Beam
On 2012/06/04 18:20:05, tony wrote: > Using old flex box for this (ordering and alignment) ...
8 years, 6 months ago (2012-06-04 19:12:12 UTC) #5
Evan Stade
so does this LG or not?
8 years, 6 months ago (2012-06-04 22:04:20 UTC) #6
Dan Beam
8 years, 6 months ago (2012-06-05 00:43:31 UTC) #7
finnnnnnnnnne lgtm (but next time we break, we revert to XUL version)

Powered by Google App Engine
This is Rietveld 408576698