Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps co…

remoting/host/breakpad.h

Index: remoting/host/breakpad.h
diff --git a/remoting/host/breakpad.h b/remoting/host/breakpad.h
new file mode 100644
index 0000000000000000000000000000000000000000..bb60b677b6018e598a047346115947ea2c168b33
--- /dev/null
+++ b/remoting/host/breakpad.h
@@ -0,0 +1,15 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_BREAKPAD_H_
+#define REMOTING_HOST_BREAKPAD_H_
+
+namespace remoting {
+
+// Initializes collection of the crash dump reports.

[Wez, 2012/06/06 15:52:03]

Why is this host-specific (under remoting/host/) rather than generally useful
(e.g. under remoting/base/)?
When does the initialization call need to be made? e.g. During host process
startup?

[Wez, 2012/06/06 15:52:03]

nit: Initializes collection & upload of crash reports if the user has consented.

[Wez, 2012/06/06 15:52:03]

nit: Initializes collection & upload of crash reports if the user has consented.

[alexeypa (please no reviews), 2012/06/06 16:53:56]

Done.

[alexeypa (please no reviews), 2012/06/06 16:53:56]

Right now the only reason is that we check a host specific location to know if
the crash reporting is enabled.
I added the explanation to the comment.

[Wez, 2012/06/07 16:56:47]

Would it add much complexity to have the Breakpad code in remoting/base and
simply initialise it with the necessary value with a constant defined under
remoting/host/?

[alexeypa (please no reviews), 2012/06/08 17:26:17]

I've split it into two base/breakpad (exception handler registration) and
host/breakpad (user consent lookup). It adds some boilerplate code. We can
probably tolerate it.

+void InitializeCrashReporting();
+
+}  // remoting
+
+#endif  // REMOTING_HOST_BREAKPAD_H_