remoting/host/breakpad.h - Issue 10495003: Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps co…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/breakpad.h

Issue 10495003: Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps co… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_BREAKPAD_H_

	6 #define REMOTING_HOST_BREAKPAD_H_

	7

	8 namespace remoting {

	9

	10 // Initializes collection of the crash dump reports.
	Wez 2012/06/06 15:52:03 Why is this host-specific (under remoting/host/) r Why is this host-specific (under remoting/host/) rather than generally useful (e.g. under remoting/base/)? When does the initialization call need to be made? e.g. During host process startup? Wez 2012/06/06 15:52:03 nit: Initializes collection & upload of crash repo nit: Initializes collection & upload of crash reports if the user has consented. Wez 2012/06/06 15:52:03 nit: Initializes collection & upload of crash repo nit: Initializes collection & upload of crash reports if the user has consented. alexeypa (please no reviews) 2012/06/06 16:53:56 Done. Show quoted text On 2012/06/06 15:52:03, Wez wrote: > nit: Initializes collection & upload of crash reports if the user has consented. Done. alexeypa (please no reviews) 2012/06/06 16:53:56 Right now the only reason is that we check a host Show quoted text On 2012/06/06 15:52:03, Wez wrote: > Why is this host-specific (under remoting/host/) rather than generally useful (e.g. under remoting/base/)? Right now the only reason is that we check a host specific location to know if the crash reporting is enabled. Show quoted text > When does the initialization call need to be made? e.g. During host process > startup? I added the explanation to the comment. Wez 2012/06/07 16:56:47 Would it add much complexity to have the Breakpad Show quoted text On 2012/06/06 16:53:56, alexeypa wrote: > On 2012/06/06 15:52:03, Wez wrote: > > Why is this host-specific (under remoting/host/) rather than generally useful > (e.g. under remoting/base/)? > > Right now the only reason is that we check a host specific location to know if > the crash reporting is enabled. Would it add much complexity to have the Breakpad code in remoting/base and simply initialise it with the necessary value with a constant defined under remoting/host/? Show quoted text > > When does the initialization call need to be made? e.g. During host process > > startup? > > I added the explanation to the comment. > alexeypa (please no reviews) 2012/06/08 17:26:17 I've split it into two base/breakpad (exception ha Show quoted text On 2012/06/07 16:56:47, Wez wrote: > Would it add much complexity to have the Breakpad code in remoting/base and > simply initialise it with the necessary value with a constant defined under > remoting/host/? I've split it into two base/breakpad (exception handler registration) and host/breakpad (user consent lookup). It adds some boilerplate code. We can probably tolerate it.
	11 void InitializeCrashReporting();

	12

	13 } // remoting

	14

	15 #endif // REMOTING_HOST_BREAKPAD_H_

OLD	NEW

« no previous file with comments | « remoting/host/DEPS ('k') | remoting/host/breakpad_linux.cc » ('j') | remoting/host/breakpad_linux.cc » ('J')