Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 10495003: Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps co… (Closed)

Created:
8 years, 6 months ago by alexeypa (please no reviews)
Modified:
8 years, 6 months ago
Reviewers:
Lambros, simonmorris, Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Make Chromoting Host report crashes to Breakpad (Windows only). The user must enable crash dumps collection by setting the "usagestats" value in the ClientState or ClientStateMedium key. BUG=130678 TEST=remoting_unittests.BreakpadWinDeathTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141239

Patch Set 1 #

Total comments: 23

Patch Set 2 : Generate unique pipe name to allow sharding of the unit tests. #

Patch Set 3 : CR feedback. Fixed synchromisation issues in the unittest. #

Patch Set 4 : Splitting into base/breakpad and host/breakpad. #

Patch Set 5 : Fixing DEPS and rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+578 lines, -11 lines) Patch
M remoting/base/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A remoting/base/breakpad.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A remoting/base/breakpad_linux.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/base/breakpad_mac.mm View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/base/breakpad_win.cc View 1 2 3 1 chunk +213 lines, -0 lines 0 comments Download
A remoting/base/breakpad_win_unittest.cc View 1 2 3 1 chunk +136 lines, -0 lines 0 comments Download
A remoting/host/breakpad.h View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A remoting/host/breakpad_win.cc View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
M remoting/host/constants.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
A remoting/host/constants_win.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M remoting/host/elevated_controller_module_win.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/host/host_service_win.cc View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M remoting/host/host_ui.rc View 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/host/plugin/daemon_installer_win.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 11 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
alexeypa (please no reviews)
PTAL.
8 years, 6 months ago (2012-06-01 22:37:38 UTC) #1
alexeypa (please no reviews)
On 2012/06/01 22:37:38, alexeypa wrote: > PTAL. More specifically I'd like Lambros to review the ...
8 years, 6 months ago (2012-06-01 22:58:19 UTC) #2
Lambros
Stubs lgtm
8 years, 6 months ago (2012-06-04 18:00:13 UTC) #3
alexeypa (please no reviews)
On 2012/06/04 18:00:13, Lambros wrote: > Stubs lgtm Wez, will you have time to take ...
8 years, 6 months ago (2012-06-05 05:35:16 UTC) #4
alexeypa (please no reviews)
+Simon. Could you take a look?
8 years, 6 months ago (2012-06-06 15:40:46 UTC) #5
Wez
https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h File remoting/host/breakpad.h (right): https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h#newcode10 remoting/host/breakpad.h:10: // Initializes collection of the crash dump reports. Why ...
8 years, 6 months ago (2012-06-06 15:52:03 UTC) #6
alexeypa (please no reviews)
https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h File remoting/host/breakpad.h (right): https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h#newcode10 remoting/host/breakpad.h:10: // Initializes collection of the crash dump reports. On ...
8 years, 6 months ago (2012-06-06 16:53:56 UTC) #7
alexeypa (please no reviews)
Ping.
8 years, 6 months ago (2012-06-07 16:52:27 UTC) #8
Wez
LGTM as-is, but with a few more questions & comments. :) https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h File remoting/host/breakpad.h (right): ...
8 years, 6 months ago (2012-06-07 16:56:47 UTC) #9
alexeypa (please no reviews)
https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h File remoting/host/breakpad.h (right): https://chromiumcodereview.appspot.com/10495003/diff/1/remoting/host/breakpad.h#newcode10 remoting/host/breakpad.h:10: // Initializes collection of the crash dump reports. On ...
8 years, 6 months ago (2012-06-08 17:26:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10495003/14002
8 years, 6 months ago (2012-06-08 17:26:42 UTC) #11
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 18:17:32 UTC) #12
Change committed as 141239

Powered by Google App Engine
This is Rietveld 408576698