Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10491007: fixed issue 128383 - replace GetPeerAddress(AddressList* address) with GetPeerAddress(IPEndPoint* a… (Closed)

Created:
8 years, 6 months ago by zhaoqin1
Modified:
8 years, 6 months ago
Reviewers:
Sergey Ulanov, szym, brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

fixed issue 128383 - replace GetPeerAddress(AddressList* address) with GetPeerAddress(IPEndPoint* address) R=szym@chromium.org BUG=128383 TEST=try bot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141125

Patch Set 1 #

Patch Set 2 : replace GetPeerAddress(AddressList* address) with GetPeerAddress(IPEndPoint* address) #

Patch Set 3 : replace GetPeerAddress(AddressList* address) with GetPeerAddress(IPEndPoint* address) #

Patch Set 4 : replace GetPeerAddress(AddressList*) with GetPeerAddress(IPEndPoint*) #

Patch Set 5 : replace GetPeerAddress(AddressList*) with GetPeerAddress(IPEndPoint*) #

Patch Set 6 : PLT #

Total comments: 7

Patch Set 7 : fix according to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -114 lines) Patch
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.h View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper_tcp_server_socket.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/pepper_tcp_socket.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.h View 1 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket_unittest.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/curvecp/curvecp_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/curvecp/curvecp_client_socket.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_parser.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/buffered_write_stream_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/buffered_write_stream_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socks5_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_mac.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_nss.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/stream_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket_libevent.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket_libevent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_win.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_client_socket_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy3_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/protocol/fake_session.h View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/fake_session.cc View 1 2 3 4 5 6 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
zhaoqin1
8 years, 6 months ago (2012-06-02 03:48:24 UTC) #1
zhaoqin
On 2012/06/02 03:48:24, zhaoqin1 wrote: Ping
8 years, 6 months ago (2012-06-06 17:03:16 UTC) #2
szym
On 2012/06/06 17:03:16, zhaoqin wrote: > On 2012/06/02 03:48:24, zhaoqin1 wrote: > > Ping Thanks ...
8 years, 6 months ago (2012-06-07 02:10:54 UTC) #3
szym
Thanks for taking care of this. LGTM https://chromiumcodereview.appspot.com/10491007/diff/12002/content/browser/renderer_host/p2p/socket_host_test_utils.h File content/browser/renderer_host/p2p/socket_host_test_utils.h (right): https://chromiumcodereview.appspot.com/10491007/diff/12002/content/browser/renderer_host/p2p/socket_host_test_utils.h#newcode184 content/browser/renderer_host/p2p/socket_host_test_utils.h:184: *address = ...
8 years, 6 months ago (2012-06-07 02:42:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@chromium.org/10491007/22001
8 years, 6 months ago (2012-06-07 19:19:08 UTC) #5
commit-bot: I haz the power
Presubmit check for 10491007-22001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-07 19:19:42 UTC) #6
zhaoqin
+sergeyu
8 years, 6 months ago (2012-06-07 19:22:43 UTC) #7
Sergey Ulanov
remotin - LGTM. Thanks for fixing it!
8 years, 6 months ago (2012-06-07 20:06:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@chromium.org/10491007/22001
8 years, 6 months ago (2012-06-07 20:31:52 UTC) #9
commit-bot: I haz the power
Presubmit check for 10491007-22001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-07 20:32:16 UTC) #10
zhaoqin
+brettw
8 years, 6 months ago (2012-06-07 20:40:45 UTC) #11
zhaoqin
brettw, please have a look at content/renderer/pepper/* changes.
8 years, 6 months ago (2012-06-07 20:45:47 UTC) #12
brettw
lgtm
8 years, 6 months ago (2012-06-07 21:49:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhaoqin@chromium.org/10491007/22001
8 years, 6 months ago (2012-06-07 21:54:30 UTC) #14
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 00:11:58 UTC) #15 
Change committed as 141125

Powered by Google App Engine
This is Rietveld 408576698