Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10479023: Simplify how Content*Client interfaces are created. Instead of depending on the embedder to know wh… (Closed)

Created:
8 years, 6 months ago by jam
Modified:
5 years, 5 months ago
Reviewers:
23Joshhansen23, Jói
CC:
chromium-reviews, robertshield, cbentzel+watch_chromium.org, sadrul, jochen+watch-content_chromium.org, ben+watch_chromium.org, tfarina, amit, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, creis+watch_chromium.org
Visibility:
Public.

Description

Simplify how Content*Client interfaces are created. Instead of depending on the embedder to know when to create and set them and to handle special cases like zygote/single-process, directly ask the embedder to create an instance of a specific type. Also, if the embedder doesn't return an instance create the empty version. Remove MockContentRendererClient since it existed before ContentRendererClient had an implementation and has no need anymore. Rename MockContentBrowserClient to TestContentBrowserClient to better reflect how it's used. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140524

Patch Set 1 #

Patch Set 2 : fix linux #

Patch Set 3 : fix chrome_frame_net_tests #

Patch Set 4 : remove unused function declaration #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -666 lines) Patch
M ash/shell/content_client/shell_main_delegate.h View 1 chunk +1 line, -7 lines 0 comments Download
M ash/shell/content_client/shell_main_delegate.cc View 3 chunks +3 lines, -29 lines 0 comments Download
M chrome/app/chrome_main_delegate.h View 2 chunks +12 lines, -8 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 5 chunks +20 lines, -32 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M content/app/content_main_runner.cc View 1 21 chunks +82 lines, -38 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
D content/browser/mock_content_browser_client.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/mock_content_browser_client.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A content/public/app/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/app/content_main_delegate.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/common/content_client.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/public/plugin/content_plugin_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/test/test_content_client_initializer.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/renderer/mock_content_renderer_client.h View 1 chunk +0 lines, -88 lines 0 comments Download
D content/renderer/mock_content_renderer_client.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D content/shell/shell_content_plugin_client.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/shell/shell_content_plugin_client.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D content/shell/shell_content_utility_client.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/shell/shell_content_utility_client.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/shell/shell_main_delegate.h View 2 chunks +4 lines, -8 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 4 chunks +12 lines, -36 lines 1 comment Download
M content/test/content_test_suite.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/render_view_fake_resources_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/test/test_content_browser_client.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + content/test/test_content_browser_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/test/test_content_client_initializer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/webrtc_audio_device_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/content_client/examples_main_delegate.h View 1 2 3 2 chunks +2 lines, -13 lines 0 comments Download
M ui/views/examples/content_client/examples_main_delegate.cc View 3 chunks +4 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jam
8 years, 6 months ago (2012-06-05 01:53:49 UTC) #1
Jói
LGTM with a nit http://codereview.chromium.org/10479023/diff/19001/content/shell/shell_main_delegate.cc File content/shell/shell_main_delegate.cc (right): http://codereview.chromium.org/10479023/diff/19001/content/shell/shell_main_delegate.cc#newcode83 content/shell/shell_main_delegate.cc:83: nit: weird blank line
8 years, 6 months ago (2012-06-05 11:26:54 UTC) #2
23Joshhansen23
5 years, 5 months ago (2015-07-15 05:13:50 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698