Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome_frame/test/net/fake_external_tab.cc

Issue 10479023: Simplify how Content*Client interfaces are created. Instead of depending on the embedder to know wh… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: remove unused function declaration Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/net/fake_external_tab.cc
===================================================================
--- chrome_frame/test/net/fake_external_tab.cc (revision 140381)
+++ chrome_frame/test/net/fake_external_tab.cc (working copy)
@@ -147,17 +147,19 @@
logging_win::InstallTestLogCollector(
testing::UnitTest::GetInstance());
- // Initialize the content client.
content::SetContentClient(&g_chrome_content_client.Get());
-
- // Override the default ContentBrowserClient to let Chrome participate in
- // content logic. We use a subclass of Chrome's implementation,
- // FakeContentBrowserClient, to override CreateBrowserMainParts. Must
- // be done before any tabs are created.
- content::GetContentClient()->set_browser(&g_browser_client.Get());
- content::GetContentClient()->set_renderer(&g_renderer_client.Get());
+ content::GetContentClient()->set_renderer_for_testing(
+ &g_renderer_client.Get());
return false;
}
+
+ // Override the default ContentBrowserClient to let Chrome participate in
+ // content logic. We use a subclass of Chrome's implementation,
+ // FakeContentBrowserClient, to override CreateBrowserMainParts. Must
+ // be done before any tabs are created.
+ virtual content::ContentBrowserClient* CreateContentBrowserClient() OVERRIDE {
+ return &g_browser_client.Get();
+ };
};
void FilterDisabledTests() {

Powered by Google App Engine
This is Rietveld 408576698