Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: chrome/test/base/bookmark_load_observer.h

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: phajdan feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/user_data_dir_dialog_view.cc ('k') | chrome/test/base/bookmark_load_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/bookmark_load_observer.h
diff --git a/chrome/test/base/bookmark_load_observer.h b/chrome/test/base/bookmark_load_observer.h
index 0619838e4ab160134c4cadfb3526160c5927d460..e95dd066675c33b8b60b4a5eb9bc19666e8ba6c8 100644
--- a/chrome/test/base/bookmark_load_observer.h
+++ b/chrome/test/base/bookmark_load_observer.h
@@ -7,7 +7,9 @@
#pragma once
#include "base/basictypes.h"
+#include "base/callback.h"
#include "base/compiler_specific.h"
+#include "base/memory/weak_ptr.h"
#include "chrome/browser/bookmarks/bookmark_model_observer.h"
// BookmarkLoadObserver is used when blocking until the BookmarkModel
@@ -15,7 +17,7 @@
// loop is quit.
class BookmarkLoadObserver : public BookmarkModelObserver {
public:
- BookmarkLoadObserver();
+ explicit BookmarkLoadObserver(const base::Closure& quit_task);
virtual ~BookmarkLoadObserver();
virtual void Loaded(BookmarkModel* model, bool ids_reassigned) OVERRIDE;
@@ -40,6 +42,7 @@ class BookmarkLoadObserver : public BookmarkModelObserver {
const BookmarkNode* node) OVERRIDE {}
private:
+ base::Closure quit_task_;
DISALLOW_COPY_AND_ASSIGN(BookmarkLoadObserver);
};
« no previous file with comments | « chrome/browser/ui/views/user_data_dir_dialog_view.cc ('k') | chrome/test/base/bookmark_load_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698