Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: chrome/test/base/bookmark_load_observer.h

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: phajdan feedback Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_ 5 #ifndef CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_
6 #define CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_ 6 #define CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h"
10 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/memory/weak_ptr.h"
11 #include "chrome/browser/bookmarks/bookmark_model_observer.h" 13 #include "chrome/browser/bookmarks/bookmark_model_observer.h"
12 14
13 // BookmarkLoadObserver is used when blocking until the BookmarkModel 15 // BookmarkLoadObserver is used when blocking until the BookmarkModel
14 // finishes loading. As soon as the BookmarkModel finishes loading the message 16 // finishes loading. As soon as the BookmarkModel finishes loading the message
15 // loop is quit. 17 // loop is quit.
16 class BookmarkLoadObserver : public BookmarkModelObserver { 18 class BookmarkLoadObserver : public BookmarkModelObserver {
17 public: 19 public:
18 BookmarkLoadObserver(); 20 explicit BookmarkLoadObserver(const base::Closure& quit_task);
19 virtual ~BookmarkLoadObserver(); 21 virtual ~BookmarkLoadObserver();
20 22
21 virtual void Loaded(BookmarkModel* model, bool ids_reassigned) OVERRIDE; 23 virtual void Loaded(BookmarkModel* model, bool ids_reassigned) OVERRIDE;
22 virtual void BookmarkNodeMoved(BookmarkModel* model, 24 virtual void BookmarkNodeMoved(BookmarkModel* model,
23 const BookmarkNode* old_parent, 25 const BookmarkNode* old_parent,
24 int old_index, 26 int old_index,
25 const BookmarkNode* new_parent, 27 const BookmarkNode* new_parent,
26 int new_index) OVERRIDE {} 28 int new_index) OVERRIDE {}
27 virtual void BookmarkNodeAdded(BookmarkModel* model, 29 virtual void BookmarkNodeAdded(BookmarkModel* model,
28 const BookmarkNode* parent, 30 const BookmarkNode* parent,
29 int index) OVERRIDE{} 31 int index) OVERRIDE{}
30 virtual void BookmarkNodeRemoved(BookmarkModel* model, 32 virtual void BookmarkNodeRemoved(BookmarkModel* model,
31 const BookmarkNode* parent, 33 const BookmarkNode* parent,
32 int old_index, 34 int old_index,
33 const BookmarkNode* node) OVERRIDE {} 35 const BookmarkNode* node) OVERRIDE {}
34 virtual void BookmarkNodeChanged(BookmarkModel* model, 36 virtual void BookmarkNodeChanged(BookmarkModel* model,
35 const BookmarkNode* node) OVERRIDE {} 37 const BookmarkNode* node) OVERRIDE {}
36 virtual void BookmarkNodeChildrenReordered( 38 virtual void BookmarkNodeChildrenReordered(
37 BookmarkModel* model, 39 BookmarkModel* model,
38 const BookmarkNode* node) OVERRIDE {} 40 const BookmarkNode* node) OVERRIDE {}
39 virtual void BookmarkNodeFaviconChanged(BookmarkModel* model, 41 virtual void BookmarkNodeFaviconChanged(BookmarkModel* model,
40 const BookmarkNode* node) OVERRIDE {} 42 const BookmarkNode* node) OVERRIDE {}
41 43
42 private: 44 private:
45 base::Closure quit_task_;
43 DISALLOW_COPY_AND_ASSIGN(BookmarkLoadObserver); 46 DISALLOW_COPY_AND_ASSIGN(BookmarkLoadObserver);
44 }; 47 };
45 48
46 #endif // CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_ 49 #endif // CHROME_TEST_BASE_BOOKMARK_LOAD_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/user_data_dir_dialog_view.cc ('k') | chrome/test/base/bookmark_load_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698