Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: phajdan feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h
diff --git a/chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h b/chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h
index 815454ff7204b780d1d9210174f8d306779e052f..dac0c037882c02d311c76f56dc63c4cff49266e8 100644
--- a/chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h
+++ b/chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h
@@ -15,14 +15,7 @@ class RenderViewContextMenu;
class ContextMenuNotificationObserver : public content::NotificationObserver {
public:
// Wait for a context menu to be shown, and then execute |command_to_execute|.
- // As the context menu might spin a nested message loop, the usual way to wait
- // for the result of the |command_to_execute|, i.e. running
- // ui_test_utils::WindowedNotificationObserver::Wait, won't work. The
- // ContextMenuNotificationObserver can work around this problem. In order to
- // do so, you need to also specify what notification the
- // WindowedNotificationObserver is waiting for.
- ContextMenuNotificationObserver(int command_to_execute,
- int expected_notification);
+ explicit ContextMenuNotificationObserver(int command_to_execute);
virtual ~ContextMenuNotificationObserver();
private:
@@ -34,8 +27,6 @@ class ContextMenuNotificationObserver : public content::NotificationObserver {
content::NotificationRegistrar registrar_;
int command_to_execute_;
- int expected_notification_;
- bool seen_expected_notification_;
DISALLOW_COPY_AND_ASSIGN(ContextMenuNotificationObserver);
};

Powered by Google App Engine
This is Rietveld 408576698