chrome/browser/tab_contents/render_view_context_menu_browsertest.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu_browsertest.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: phajdan feedback Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/referrer_policy_browsertest.cc ('k') | chrome/browser/tab_contents/render_view_context_menu_browsertest_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu_browsertest.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc b/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc

index e95b26cb15e089e35bf05b03ec146c8326c72490..362d57fe6b7b137b056be0aa534b5d6e56c7f829 100644

--- a/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu_browsertest.cc

@@ -101,8 +101,7 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,

IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,

MAYBE_RealMenu) {

ContextMenuNotificationObserver menu_observer(

- IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,

- chrome::NOTIFICATION_TAB_ADDED);

+ IDC_CONTENT_CONTEXT_OPENLINKNEWTAB);

ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(

content::NotificationService::AllSources());