Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc

Index: chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc
diff --git a/chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc b/chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc
index e21efb75cd5d0971f88e8a780eaa4befe195f94c..d683a8ed30d233e140cd6196a725cd9ada00d88a 100644
--- a/chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc
+++ b/chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc
@@ -85,6 +85,7 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
 
   ASSERT_FALSE(IsFullscreenBubbleDisplayed());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);

[Paweł Hajdan Jr., 2012/06/18 15:56:25]

Ouch, some debugging code? This can't be a part of the commit - or maybe you
want to convert these to LOG?

[jbates, 2012/06/18 23:14:03]

Done.

   // Request to lock the mouse and enter fullscreen.
   {
     FullscreenNotificationObserver fullscreen_observer;
@@ -92,20 +93,24 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
         browser(), ui::VKEY_B, false, true, false, false,
         chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
         content::NotificationService::AllSources()));
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
   }
   ASSERT_TRUE(IsFullscreenPermissionRequested());
   ASSERT_TRUE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Escape, no prompts should remain.
   {
     FullscreenNotificationObserver fullscreen_observer;
     SendEscapeToFullscreenController();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
   }
   ASSERT_FALSE(IsFullscreenPermissionRequested());
   ASSERT_FALSE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Request to lock the mouse and enter fullscreen.
   {
     FullscreenNotificationObserver fullscreen_observer;
@@ -113,11 +118,15 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
         browser(), ui::VKEY_B, false, true, false, false,
         chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
         content::NotificationService::AllSources()));
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   }
   ASSERT_TRUE(IsFullscreenPermissionRequested());
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   ASSERT_TRUE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Accept both, confirm mouse lock and fullscreen and no prompts.
   AcceptCurrentFullscreenOrMouseLockRequest();
   ASSERT_TRUE(IsMouseLocked());
@@ -125,11 +134,15 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
   ASSERT_FALSE(IsFullscreenPermissionRequested());
   ASSERT_FALSE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Escape, confirm we are out of mouse lock and fullscreen with no prompts.
   {
     FullscreenNotificationObserver fullscreen_observer;
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     SendEscapeToFullscreenController();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   }
   ASSERT_FALSE(IsMouseLocked());
   ASSERT_FALSE(IsFullscreenForTabOrPending());