Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

chrome/browser/ui/fullscreen_controller_interactive_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/fullscreen_controller_test.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 
@@ skipping 67 matching lines @@
 
 // Tests mouse lock and fullscreen modes can be escaped with ESC key.
 IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
                        EscapingMouseLockAndFullscreen) {
   ASSERT_TRUE(test_server()->Start());
   ui_test_utils::NavigateToURL(browser(),
                                test_server()->GetURL(kFullscreenMouseLockHTML));
 
   ASSERT_FALSE(IsFullscreenBubbleDisplayed());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);

[Paweł Hajdan Jr., 2012/06/18 15:56:25]

Ouch, some debugging code? This can't be a part of the commit - or maybe you
want to convert these to LOG?

[jbates, 2012/06/18 23:14:03]

Done.

   // Request to lock the mouse and enter fullscreen.
   {
     FullscreenNotificationObserver fullscreen_observer;
     ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait(
         browser(), ui::VKEY_B, false, true, false, false,
         chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
         content::NotificationService::AllSources()));
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
   }
   ASSERT_TRUE(IsFullscreenPermissionRequested());
   ASSERT_TRUE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Escape, no prompts should remain.
   {
     FullscreenNotificationObserver fullscreen_observer;
     SendEscapeToFullscreenController();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
   }
   ASSERT_FALSE(IsFullscreenPermissionRequested());
   ASSERT_FALSE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Request to lock the mouse and enter fullscreen.
   {
     FullscreenNotificationObserver fullscreen_observer;
     ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait(
         browser(), ui::VKEY_B, false, true, false, false,
         chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
         content::NotificationService::AllSources()));
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   }
   ASSERT_TRUE(IsFullscreenPermissionRequested());
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   ASSERT_TRUE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Accept both, confirm mouse lock and fullscreen and no prompts.
   AcceptCurrentFullscreenOrMouseLockRequest();
   ASSERT_TRUE(IsMouseLocked());
   ASSERT_TRUE(IsFullscreenForTabOrPending());
   ASSERT_FALSE(IsFullscreenPermissionRequested());
   ASSERT_FALSE(IsMouseLockPermissionRequested());
 
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   // Escape, confirm we are out of mouse lock and fullscreen with no prompts.
   {
     FullscreenNotificationObserver fullscreen_observer;
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     SendEscapeToFullscreenController();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
     fullscreen_observer.Wait();
+fprintf(stderr, "global %s:%s:%d\n", __FILE__, __FUNCTION__, (int)__LINE__);
   }
   ASSERT_FALSE(IsMouseLocked());
   ASSERT_FALSE(IsFullscreenForTabOrPending());
   ASSERT_FALSE(IsFullscreenPermissionRequested());
   ASSERT_FALSE(IsMouseLockPermissionRequested());
 }
 
 // Tests mouse lock then fullscreen.
 IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,
                        MouseLockThenFullscreen) {
@@ skipping 168 matching lines @@
 
   // Lock the mouse with a user gesture, make sure we see bubble again
   ASSERT_TRUE(ui_test_utils::SendKeyPressAndWait(
       browser(), ui::VKEY_1, false, false, false, false,
       chrome::NOTIFICATION_MOUSE_LOCK_CHANGED,
       content::NotificationService::AllSources()));
   ASSERT_TRUE(IsFullscreenBubbleDisplayed());
   ASSERT_TRUE(IsMouseLocked());
 }