Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: chrome/test/base/ui_test_utils.h

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more test fixes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/ui_test_utils.h
diff --git a/chrome/test/base/ui_test_utils.h b/chrome/test/base/ui_test_utils.h
index 086d084c2ec9c2eff9da38e89a056d13441d80d9..763676a6435654fba3c2f7d2c1e52f977b17193b 100644
--- a/chrome/test/base/ui_test_utils.h
+++ b/chrome/test/base/ui_test_utils.h
@@ -314,27 +314,16 @@ class TimedMessageLoopRunner {
// Attach to an existing message loop.
explicit TimedMessageLoopRunner(MessageLoop* loop)
- : loop_(loop), owned_(false), quit_loop_invoked_(false) {}
+ : loop_(loop), owned_(false) {}
jar (doing other things) 2012/06/08 01:05:37 nit: one constructor init per line (even if the ol
jbates 2012/06/13 22:11:20 Done.
~TimedMessageLoopRunner();
// Run the message loop for ms milliseconds.
void RunFor(int ms);
- // Post Quit task to the message loop.
- void Quit();
-
- // Post delayed Quit task to the message loop.
- void QuitAfter(int ms);
-
- bool WasTimedOut() const {
- return !quit_loop_invoked_;
- }
-
private:
MessageLoop* loop_;
bool owned_;
- bool quit_loop_invoked_;
DISALLOW_COPY_AND_ASSIGN(TimedMessageLoopRunner);
};

Powered by Google App Engine
This is Rietveld 408576698