Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

chrome/test/base/ui_test_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_UI_TEST_UTILS_H_
 #define CHROME_TEST_BASE_UI_TEST_UTILS_H_
 #pragma once
 
 #include <map>
 #include <queue>
@@ skipping 296 matching lines @@
                          int state) WARN_UNUSED_RESULT;
 
 // Run a message loop only for the specified amount of time.
 class TimedMessageLoopRunner {
  public:
   // Create new MessageLoopForUI and attach to it.
   TimedMessageLoopRunner();
 
   // Attach to an existing message loop.
   explicit TimedMessageLoopRunner(MessageLoop* loop)
-      : loop_(loop), owned_(false), quit_loop_invoked_(false) {}
+      : loop_(loop), owned_(false) {}

[jar (doing other things), 2012/06/08 01:05:37]

nit: one constructor init per line (even if the old code was missing this).

[jbates, 2012/06/13 22:11:20]

Done.

 
   ~TimedMessageLoopRunner();
 
   // Run the message loop for ms milliseconds.
   void RunFor(int ms);
 
-  // Post Quit task to the message loop.
-  void Quit();
-
-  // Post delayed Quit task to the message loop.
-  void QuitAfter(int ms);
-
-  bool WasTimedOut() const {
-    return !quit_loop_invoked_;
-  }
-
  private:
   MessageLoop* loop_;
   bool owned_;
-  bool quit_loop_invoked_;
 
   DISALLOW_COPY_AND_ASSIGN(TimedMessageLoopRunner);
 };
 
 // This is a utility class for running a python websocket server
 // during tests. The server is started during the construction of the
 // object, and is stopped when the destructor is called. Note that
 // because of the underlying script that is used:
 //
 //    third_paty/WebKit/Tools/Scripts/new-run-webkit-websocketserver
@@ skipping 346 matching lines @@
 // ui_controls_linux.cc and ui_controls_mac.cc
 void ClickTask(ui_controls::MouseButton button,
                int state,
                const base::Closure& followup);
 
 }  // namespace internal
 
 }  // namespace ui_test_utils
 
 #endif  // CHROME_TEST_BASE_UI_TEST_UTILS_H_