chrome/browser/extensions/extension_browsertest.cc - Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 10479018: Add base::RunLoop and update ui_test_utils to use it to reduce flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added printfs to debug timeout which doesn't happen locally Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/message_loop.cc ('K') | « chrome/browser/crash_recovery_browsertest.cc ('k') | chrome/browser/referrer_policy_browsertest.cc » ('j') | chrome/browser/referrer_policy_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index 5faf4b39fa7d54022144bc93ece6409a5b89ab2f..8c527659c74b1ee2936724e960fc8a74d7f7d913 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -139,6 +139,10 @@ const Extension* ExtensionBrowserTest::LoadExtensionWithOptions(

}

+ // After chrome::NOTIFICATION_EXTENSION_LOADED there are still remaining tasks

+ // that need to complete for extensions to be in a settled load state.

+ ui_test_utils::RunAllPendingInMessageLoop();

if (!WaitForExtensionViewsToLoad())

return NULL;

« base/message_loop.cc ('K') | « chrome/browser/crash_recovery_browsertest.cc ('k') | chrome/browser/referrer_policy_browsertest.cc » ('j') | chrome/browser/referrer_policy_browsertest.cc » ('J')