Add base::RunLoop and update ui_test_utils to use it to reduce flakiness

chrome/browser/extensions/extension_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_browsertest.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
@@ skipping 121 matching lines @@
     CHECK(service->AllowFileAccess(extension));
 
     if (!fileaccess_enabled) {
       service->SetAllowFileAccess(extension, fileaccess_enabled);
       load_signal.Wait();
       extension = service->GetExtensionById(extension_id, false);
       CHECK(extension) << extension_id << " not found after reloading.";
     }
   }
 
+  // After chrome::NOTIFICATION_EXTENSION_LOADED there are still remaining tasks
+  // that need to complete for extensions to be in a settled load state.
+  ui_test_utils::RunAllPendingInMessageLoop();
+
   if (!WaitForExtensionViewsToLoad())
     return NULL;
 
   return extension;
 }
 
 const Extension* ExtensionBrowserTest::LoadExtension(const FilePath& path) {
   return LoadExtensionWithOptions(path, false, true);
 }
 
@@ skipping 144 matching lines @@
     FilePath crx_path = path;
     if (crx_path.Extension() != FILE_PATH_LITERAL(".crx")) {
       crx_path = PackExtension(path);
     }
     if (crx_path.empty())
       return NULL;
 
     scoped_refptr<CrxInstaller> installer(
         CrxInstaller::Create(service, install_ui));
     installer->set_expected_id(id);
     installer->set_allow_off_store_install(true);

[jar (doing other things), 2012/06/14 04:50:29]

nit: I couldn't guess what this method does.  I suspect it is a bad name.

[jbates, 2012/06/15 02:20:38]

I'm just in here to fix some flakiness, not all that sure what this code does.

     installer->set_is_gallery_install(from_webstore);
 
     content::NotificationRegistrar registrar;
     registrar.Add(this, chrome::NOTIFICATION_CRX_INSTALLER_DONE,
                   content::Source<CrxInstaller>(installer.get()));
 
     installer->InstallCrx(crx_path);
 
     ui_test_utils::RunMessageLoop();
   }
@@ skipping 271 matching lines @@
     case content::NOTIFICATION_LOAD_STOP:
       VLOG(1) << "Got LOAD_STOP notification.";
       MessageLoopForUI::current()->Quit();
       break;
 
     default:
       NOTREACHED();
       break;
   }
 }