Increase Chrome SPDY/3 stream receive window to 10MB.

Increase Chrome SPDY/3 stream receive window to 10MB.  The goal is to set the SPDY window high enough that we'd never realistically hit it, since we'd hit TCP flow control first. The buffers are kept in the Chrome browser process, which should ship things over to WebKit immediately, so the buffers should almost always be small, unless the renderer process goes out to lunch or we're getting a ton of server pushed stuff (unless it goes to browser cache, but I don't think we do that yet, but I forget). 10MB per stream prevents us from completely hosing the browser process in these exceptional situations

Change SpdySession so that if the initial receive window size is larger than
the protocol default, notify the server.

Rename SendSettings to SendInitialSettings to be more clear.

BUG=131055
TEST=SpdySessionSpdy3Test.SendInitialWindowSizeSettingsOnNewSession

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140433

[ramant (doing other things), 2012-06-04 20:22:35]

lgtm

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1714: // initial window size.
nit: could we update the comment (because initial window size could be
overwritten by what is persisted).

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1727: QueueFrame(settings_frame.get(), HIGHEST, NULL);
nit: Should we delete the commented out code?

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1735: // told use to use when communicating with them.
nit: could we update this comment because we are not sending two SETTING frames?
thanks

[Ryan Hamilton, 2012-06-04 20:48:50]

Thanks for the lgtm.  Since I ended up having to make a code change (to send 2
frames) would you mind taking a quick second look?

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1714: // initial window size.
On 2012/06/04 20:22:35, ramant wrote:
> nit: could we update the comment (because initial window size could be
> overwritten by what is persisted).

Ugh.  That would be a bug.  We do not want to overwrite *our* window size with
the server's window size.  We need two frames.

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1727: QueueFrame(settings_frame.get(), HIGHEST, NULL);
On 2012/06/04 20:22:35, ramant wrote:
> nit: Should we delete the commented out code?

Whoops!  Done.  (Now factored into a new helper method)

http://codereview.chromium.org/10479014/diff/2001/net/spdy/spdy_session.cc#ne...
net/spdy/spdy_session.cc:1735: // told use to use when communicating with them.
On 2012/06/04 20:22:35, ramant wrote:
> nit: could we update this comment because we are not sending two SETTING
frames?
> thanks

Since I had to change the code, I kept the comment at as.

[ramant (doing other things), 2012-06-04 22:29:00]

lgtm

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:235: // Sets the initial recieve window size for newly
created sessions.
nit: recieve -> receive

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session_spdy3...
File net/spdy/spdy_session_spdy3_unittest.cc (right):

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session_spdy3...
net/spdy/spdy_session_spdy3_unittest.cc:694: 
nit: please delete extra blank lines.

[Ryan Hamilton, 2012-06-04 22:34:44]

Thanks!

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session.h
File net/spdy/spdy_session.h (right):

http://codereview.chromium.org/10479014/diff/6001/net/spdy/spdy_session.h#new...
net/spdy/spdy_session.h:235: // Sets the initial recieve window size for newly
created sessions.
On 2012/06/04 22:29:00, ramant wrote:
> nit: recieve -> receive

Done.

[commit-bot: I haz the power, 2012-06-04 22:36:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/10479014/10001

[commit-bot: I haz the power, 2012-06-04 23:49:58]

Change committed as 140433