Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 10479010: Gesture related changes for views: (Closed)

Created:
8 years, 6 months ago by sky
Modified:
8 years, 6 months ago
CC:
chromium-reviews, tfarina, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

Gesture related changes for views: . Makes capture send both gesture and mouse events to the same view. . Makes gesture handling consistant with mouse handling. We only handle targetting a single view and reset the target on touch up. BUG=124277 TEST=none R=ben@chromium.org,sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140487

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix test and add some mores #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -42 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/views/view.h View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/view.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 3 chunks +131 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 6 chunks +42 lines, -16 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 chunks +11 lines, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 1 4 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
In theory we could make rootview handle multiple views being the target of a particular ...
8 years, 6 months ago (2012-06-04 15:17:38 UTC) #1
Ben Goodger (Google)
sadrul, please look first
8 years, 6 months ago (2012-06-04 15:19:49 UTC) #2
sadrul
LGTM http://codereview.chromium.org/10479010/diff/1/ui/views/widget/root_view.cc File ui/views/widget/root_view.cc (right): http://codereview.chromium.org/10479010/diff/1/ui/views/widget/root_view.cc#newcode387 ui/views/widget/root_view.cc:387: // release (or keep it if captured). It ...
8 years, 6 months ago (2012-06-04 16:23:32 UTC) #3
sky
http://codereview.chromium.org/10479010/diff/1/ui/views/widget/root_view.cc File ui/views/widget/root_view.cc (right): http://codereview.chromium.org/10479010/diff/1/ui/views/widget/root_view.cc#newcode387 ui/views/widget/root_view.cc:387: // release (or keep it if captured). On 2012/06/04 ...
8 years, 6 months ago (2012-06-04 16:25:20 UTC) #4
sky
I fixed a test and add some mores. Don't feel you have to review again ...
8 years, 6 months ago (2012-06-04 22:53:07 UTC) #5
Ben Goodger (Google)
8 years, 6 months ago (2012-06-04 22:54:51 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698