Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1047123002: Fix font selection for combining character sequences (Closed)

Created:
5 years, 8 months ago by Kunihiko Sakamoto
Modified:
5 years, 8 months ago
Reviewers:
eae, behdad
CC:
blink-reviews, Dominik Röttsches, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix font selection for combining character sequences Before this patch, SimpleFontData::canRenderCombiningCharacterSequence() tried to determine if given SimpleFontData can render the sequence by using SkPaint::textToGlyphs(), but it was always returning true. After this patch, it returns true if the SimpleFontData has glyphs for all the codepoints in the sequence. BUG=464148 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193236

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/missing-glyph-in-combining-character-sequence.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/text/missing-glyph-in-combining-character-sequence-expected.png View Binary file 0 comments Download
A LayoutTests/platform/linux/fast/text/missing-glyph-in-combining-character-sequence-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.cpp View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Kunihiko Sakamoto
5 years, 8 months ago (2015-04-01 05:25:59 UTC) #3
khaledhosny
On 2015/04/01 05:25:59, Kunihiko Sakamoto wrote: I’m not familiar with Blink code, but HarfBuzz can ...
5 years, 8 months ago (2015-04-01 14:20:20 UTC) #4
eae
Makes sense to me, behdad how does this approach look to you?
5 years, 8 months ago (2015-04-01 15:57:58 UTC) #6
behdad_google
On 2015/04/01 15:57:58, eae wrote: > Makes sense to me, behdad how does this approach ...
5 years, 8 months ago (2015-04-06 04:17:26 UTC) #7
eae
LGTM
5 years, 8 months ago (2015-04-06 15:26:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047123002/20001
5 years, 8 months ago (2015-04-07 01:10:09 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 02:43:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193236

Powered by Google App Engine
This is Rietveld 408576698