Fix wrong timing when audio is muted.

Fix wrong timing when audio is muted.

BUG=131039
TEST=Added case to unit tests, and test in the bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140405

[enal1, 2012-06-04 19:40:46]

Andrew, can you please take a look?

[scherkus (not reviewing), 2012-06-04 20:27:34]

Can you separate the alignment change from the bug fix? I don't see a reason to
combine the two.

[enal1, 2012-06-04 20:48:01]

Separated.

Initially made aligned data change when investigating supposed latency
regression. Right now I believe it is caused by combination of Linux and audio
hardware, discussing with Shadi.

[DaleCurtis, 2012-06-04 20:48:12]

https://chromiumcodereview.appspot.com/10466007/diff/1/media/audio/audio_outp...
File media/audio/audio_output_mixer.cc (right):

https://chromiumcodereview.appspot.com/10466007/diff/1/media/audio/audio_outp...
media/audio/audio_output_mixer.cc:32: mixer_data_.reset(
Drive by: if you don't mind a 32 byte alignment you could back this with a
DecoderBuffer which uses FFmpeg alignment and does the right thing on say ARM
platforms. Maybe I should have named it AlignedBuffer :)

[enal1, 2012-06-04 20:52:11]

On 2012/06/04 20:48:12, DaleCurtis wrote:
>
https://chromiumcodereview.appspot.com/10466007/diff/1/media/audio/audio_outp...
> File media/audio/audio_output_mixer.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10466007/diff/1/media/audio/audio_outp...
> media/audio/audio_output_mixer.cc:32: mixer_data_.reset(
> Drive by: if you don't mind a 32 byte alignment you could back this with a
> DecoderBuffer which uses FFmpeg alignment and does the right thing on say ARM
> platforms. Maybe I should have named it AlignedBuffer :)

Will use in a separate CL.

[scherkus (not reviewing), 2012-06-04 20:52:51]

can you update the CL description to remove the stuff about alignment?

lgtm w/ nits

https://chromiumcodereview.appspot.com/10466007/diff/7001/media/audio/audio_o...
File media/audio/audio_output_mixer.cc (right):

https://chromiumcodereview.appspot.com/10466007/diff/7001/media/audio/audio_o...
media/audio/audio_output_mixer.cc:198: // No need to mix muted stream.
nit: remove outdated comment?

https://chromiumcodereview.appspot.com/10466007/diff/7001/media/audio/audio_u...
File media/audio/audio_util.cc (right):

https://chromiumcodereview.appspot.com/10466007/diff/7001/media/audio/audio_u...
media/audio/audio_util.cc:286: } else if (volume == 1.0f) {
nit: no need for else

[commit-bot: I haz the power, 2012-06-04 20:57:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/enal@chromium.org/10466007/15001

[commit-bot: I haz the power, 2012-06-04 22:35:20]

Change committed as 140405