Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: vm/compiler.cc

Issue 10462004: Temporarily disable FlowGraphOptimizer on ia32 to make tests pass with --use_new_compiler on. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/compiler.cc
===================================================================
--- vm/compiler.cc (revision 8190)
+++ vm/compiler.cc (working copy)
@@ -195,7 +195,13 @@
for (intptr_t i = length - 1; i >= 0; --i) {
block_order.Add(graph_builder.postorder_block_entries()[i]);
}
+ // TODO(fschneider): Temporarily disable on ia32 until all instruction
regis 2012/06/01 13:08:41 instructions
Florian Schneider 2012/06/01 16:05:05 Done.
+ // produced by the FlowGraphOptimizer are implemented on ia32.
+#if defined(TARGET_ARCH_X64)
regis 2012/06/01 13:08:41 I would have made the workaround dependent on TARG
Florian Schneider 2012/06/01 16:05:05 Done.
if (optimized) {
+#else
+ if (optimized && !FLAG_use_new_compiler) {
+#endif
FlowGraphOptimizer optimizer(block_order);
optimizer.ApplyICData();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698