Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: vm/compiler.cc

Issue 10462004: Temporarily disable FlowGraphOptimizer on ia32 to make tests pass with --use_new_compiler on. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 FlowGraphBuilder graph_builder(parsed_function); 188 FlowGraphBuilder graph_builder(parsed_function);
189 graph_builder.BuildGraph(optimized); 189 graph_builder.BuildGraph(optimized);
190 190
191 // The non-optimizing compiler compiles blocks in reverse postorder, 191 // The non-optimizing compiler compiles blocks in reverse postorder,
192 // because it is a 'natural' order for the human reader of the 192 // because it is a 'natural' order for the human reader of the
193 // generated code. 193 // generated code.
194 intptr_t length = graph_builder.postorder_block_entries().length(); 194 intptr_t length = graph_builder.postorder_block_entries().length();
195 for (intptr_t i = length - 1; i >= 0; --i) { 195 for (intptr_t i = length - 1; i >= 0; --i) {
196 block_order.Add(graph_builder.postorder_block_entries()[i]); 196 block_order.Add(graph_builder.postorder_block_entries()[i]);
197 } 197 }
198 // TODO(fschneider): Temporarily disable on ia32 until all instruction
regis 2012/06/01 13:08:41 instructions
Florian Schneider 2012/06/01 16:05:05 Done.
199 // produced by the FlowGraphOptimizer are implemented on ia32.
200 #if defined(TARGET_ARCH_X64)
regis 2012/06/01 13:08:41 I would have made the workaround dependent on TARG
Florian Schneider 2012/06/01 16:05:05 Done.
198 if (optimized) { 201 if (optimized) {
202 #else
203 if (optimized && !FLAG_use_new_compiler) {
204 #endif
199 FlowGraphOptimizer optimizer(block_order); 205 FlowGraphOptimizer optimizer(block_order);
200 optimizer.ApplyICData(); 206 optimizer.ApplyICData();
201 } 207 }
202 } 208 }
203 209
204 Assembler assembler; 210 Assembler assembler;
205 FlowGraphCompiler graph_compiler(&assembler, parsed_function, 211 FlowGraphCompiler graph_compiler(&assembler, parsed_function,
206 block_order, optimized); 212 block_order, optimized);
207 { 213 {
208 TimerScope timer(FLAG_compiler_stats, 214 TimerScope timer(FLAG_compiler_stats,
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 isolate->object_store()->clear_sticky_error(); 553 isolate->object_store()->clear_sticky_error();
548 isolate->set_long_jump_base(base); 554 isolate->set_long_jump_base(base);
549 return result.raw(); 555 return result.raw();
550 } 556 }
551 UNREACHABLE(); 557 UNREACHABLE();
552 return Object::null(); 558 return Object::null();
553 } 559 }
554 560
555 561
556 } // namespace dart 562 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698