Load user custom wallpaper after browser crash.

Load user custom wallpaper after browser crash.


BUG=129810
TEST=
1. Login
2. Set custom wallpaper for desktop background
3. Trigger a chrome crash (about://inducebrowsercrashforrealz)
4. Observe the desktop wallpaper
5. Go to "Set wallpaper" settings dialog and look for the custom added wallpaper thumbnail

Verify that custom wallpaper restored after chrome crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140312

[bshe, 2012-05-28 20:51:17]

Hi Nikita.

Could you take a look at this CL since it mostly touches user_manager related
code? It should be able to fix the problem of custom wallpaper didn't restore
after a browser crash.

Thanks!

[bshe, 2012-05-30 16:59:40]

On 2012/05/28 20:51:17, bshe wrote:
> Hi Nikita.
> 
> Could you take a look at this CL since it mostly touches user_manager related
> code? It should be able to fix the problem of custom wallpaper didn't restore
> after a browser crash.
> 
> Thanks!

friendly ping?

[Nikita (slow), 2012-05-30 17:25:06]

lgtm

http://codereview.chromium.org/10459003/diff/2001/ash/accelerators/accelerato...
File ash/accelerators/accelerator_controller.cc (right):

http://codereview.chromium.org/10459003/diff/2001/ash/accelerators/accelerato...
ash/accelerators/accelerator_controller.cc:140:
desktop_background_controller->SetDesktopBackgroundSolidColorMode();
Both blocks should have { }

http://codereview.chromium.org/10459003/diff/2001/ash/desktop_background/desk...
File ash/desktop_background/desktop_background_controller.cc (right):

http://codereview.chromium.org/10459003/diff/2001/ash/desktop_background/desk...
ash/desktop_background/desktop_background_controller.cc:167: SkBitmap dummy;
related question: So is this a black background by default then?
With the transparent sign in screen I'll have to change that so that initially
it is loaded with 0xfefefe (default sign in screen bg color).

[bshe, 2012-05-30 23:33:05]

Done. Thanks!

+sky for OWNERS:
ash/*

+jhawkins for OWNERS:
chrome/browser/ui/webui/options2

https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
File ash/accelerators/accelerator_controller.cc (right):

https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
ash/accelerators/accelerator_controller.cc:140:
desktop_background_controller->SetDesktopBackgroundSolidColorMode();
On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> Both blocks should have { }

Done.

https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_controller.cc (right):

https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
ash/desktop_background/desktop_background_controller.cc:167: SkBitmap dummy;
Yes, this creates a black background for stub user or before user login. You
probably want to modify SetDesktopBackgroundSolidColorMode function to get what
you need(oxfefefe wallpaper). Since we are going to support solid color
background anyway, I can file a bug and submit a patch to make it default to
0xfefefe background if you want. 

On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> related question: So is this a black background by default then?
> With the transparent sign in screen I'll have to change that so that initially
> it is loaded with 0xfefefe (default sign in screen bg color).

[sky, 2012-05-31 00:20:31]

LGTM

https://chromiumcodereview.appspot.com/10459003/diff/10001/ash/accelerators/a...
File ash/accelerators/accelerator_controller.cc (right):

https://chromiumcodereview.appspot.com/10459003/diff/10001/ash/accelerators/a...
ash/accelerators/accelerator_controller.cc:156: } else {
nit: spacing is off here.

[Nikita (slow), 2012-05-31 17:07:03]

On 2012/05/30 23:33:05, bshe wrote:
> Done. Thanks!
> 
> +sky for OWNERS:
> ash/*
> 
> +jhawkins for OWNERS:
> chrome/browser/ui/webui/options2
> 
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
> File ash/accelerators/accelerator_controller.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
> ash/accelerators/accelerator_controller.cc:140:
> desktop_background_controller->SetDesktopBackgroundSolidColorMode();
> On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> > Both blocks should have { }
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
> File ash/desktop_background/desktop_background_controller.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
> ash/desktop_background/desktop_background_controller.cc:167: SkBitmap dummy;
> Yes, this creates a black background for stub user or before user login. You
> probably want to modify SetDesktopBackgroundSolidColorMode function to get
what
> you need(oxfefefe wallpaper). Since we are going to support solid color
> background anyway, I can file a bug and submit a patch to make it default to
> 0xfefefe background if you want. 

Yes, that would be very helpful if you could implement this in the next week.
Thanks in advance!

> 
> On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> > related question: So is this a black background by default then?
> > With the transparent sign in screen I'll have to change that so that
initially
> > it is loaded with 0xfefefe (default sign in screen bg color).

[bshe, 2012-06-01 15:59:44]

+jhawkins 
friendly ping
for chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc

On 2012/05/31 17:07:03, Nikita Kostylev wrote:
> On 2012/05/30 23:33:05, bshe wrote:
> > Done. Thanks!
> > 
> > +sky for OWNERS:
> > ash/*
> > 
> > +jhawkins for OWNERS:
> > chrome/browser/ui/webui/options2
> > 
> >
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
> > File ash/accelerators/accelerator_controller.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/accelerators/ac...
> > ash/accelerators/accelerator_controller.cc:140:
> > desktop_background_controller->SetDesktopBackgroundSolidColorMode();
> > On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> > > Both blocks should have { }
> > 
> > Done.
> > 
> >
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
> > File ash/desktop_background/desktop_background_controller.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10459003/diff/2001/ash/desktop_backgro...
> > ash/desktop_background/desktop_background_controller.cc:167: SkBitmap dummy;
> > Yes, this creates a black background for stub user or before user login. You
> > probably want to modify SetDesktopBackgroundSolidColorMode function to get
> what
> > you need(oxfefefe wallpaper). Since we are going to support solid color
> > background anyway, I can file a bug and submit a patch to make it default to
> > 0xfefefe background if you want. 
> 
> Yes, that would be very helpful if you could implement this in the next week.
> Thanks in advance!
> 
> > 
> > On 2012/05/30 17:25:06, Nikita Kostylev wrote:
> > > related question: So is this a black background by default then?
> > > With the transparent sign in screen I'll have to change that so that
> initially
> > > it is loaded with 0xfefefe (default sign in screen bg color).

[James Hawkins, 2012-06-04 16:00:04]

LGTM

[commit-bot: I haz the power, 2012-06-04 16:10:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10459003/8003

[commit-bot: I haz the power, 2012-06-04 17:12:24]

Change committed as 140312