Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3077)

Unified Diff: chrome/browser/ui/views/password_generation_bubble_view.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/password_generation_bubble_view.h
diff --git a/chrome/browser/ui/views/password_generation_bubble_view.h b/chrome/browser/ui/views/password_generation_bubble_view.h
index fb24ede894d1c4c51c138caa5280f11854d47727..9fe5c7a6ac70301e09de2711abce68760a94b580 100644
--- a/chrome/browser/ui/views/password_generation_bubble_view.h
+++ b/chrome/browser/ui/views/password_generation_bubble_view.h
@@ -6,7 +6,7 @@
#define CHROME_BROWSER_UI_VIEWS_PASSWORD_GENERATION_BUBBLE_VIEW_H_
#pragma once
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
#include "ui/gfx/rect.h"
#include "ui/views/bubble/bubble_delegate.h"
#include "ui/views/controls/button/button.h"
@@ -14,6 +14,10 @@
#include "ui/views/view.h"
#include "webkit/forms/password_form.h"
+namespace autofill {
+class PasswordGenerator;
+}
+
namespace content {
class PageNavigator;
class RenderViewHost;
@@ -38,6 +42,7 @@ class PasswordGenerationBubbleView : public views::BubbleDelegateView,
const webkit::forms::PasswordForm& form,
views::View* anchor_view,
content::RenderViewHost* render_view_host,
+ autofill::PasswordGenerator* password_generator,
content::PageNavigator* navigator,
PasswordManager* password_manager);
virtual ~PasswordGenerationBubbleView();
@@ -70,6 +75,9 @@ class PasswordGenerationBubbleView : public views::BubbleDelegateView,
// RenderViewHost associated with the button that spawned this bubble.
content::RenderViewHost* render_view_host_;
+ // Object to generate passwords. The class won't take the ownership of it.
+ autofill::PasswordGenerator* password_generator_;
+
// An object used to handle page loads that originate from link clicks
// within this UI.
content::PageNavigator* navigator_;
@@ -77,9 +85,6 @@ class PasswordGenerationBubbleView : public views::BubbleDelegateView,
// PasswordManager associated with this tab.
PasswordManager* password_manager_;
- // Class to generate passwords
- autofill::PasswordGenerator password_generator_;
-
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleView);
};
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/password_generation_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698