Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8353)

Unified Diff: chrome/browser/ui/views/password_generation_bubble_view.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/password_generation_bubble_view.h ('k') | chrome/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/password_generation_bubble_view.cc
diff --git a/chrome/browser/ui/views/password_generation_bubble_view.cc b/chrome/browser/ui/views/password_generation_bubble_view.cc
index 62c0acc61f9c1b3aa59fe00a07b56346b1c44d6e..1e82e3a7442d48672fc4f5865f5c08ae4d4ad2a5 100644
--- a/chrome/browser/ui/views/password_generation_bubble_view.cc
+++ b/chrome/browser/ui/views/password_generation_bubble_view.cc
@@ -31,6 +31,7 @@ PasswordGenerationBubbleView::PasswordGenerationBubbleView(
const webkit::forms::PasswordForm& form,
views::View* anchor_view,
content::RenderViewHost* render_view_host,
+ autofill::PasswordGenerator* password_generator,
content::PageNavigator* navigator,
PasswordManager* password_manager)
: BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),
@@ -39,6 +40,7 @@ PasswordGenerationBubbleView::PasswordGenerationBubbleView(
anchor_rect_(anchor_rect),
form_(form),
render_view_host_(render_view_host),
+ password_generator_(password_generator),
navigator_(navigator),
password_manager_(password_manager) {}
@@ -51,7 +53,8 @@ void PasswordGenerationBubbleView::Init() {
ASCIIToUTF16("Try It"));
text_field_ = new views::Textfield();
- text_field_->SetText(ASCIIToUTF16(password_generator_.Generate()));
+ text_field_->SetText(
+ ASCIIToUTF16(password_generator_->Generate()));
views::Label* title_label = new views::Label(
ASCIIToUTF16("Password Suggestion"));
« no previous file with comments | « chrome/browser/ui/views/password_generation_bubble_view.h ('k') | chrome/common/autofill_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698