Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/password_generator_unittest.cc ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index ecd20d2eb2a511a26945dd5be1542bd836358d97..ac6b9200a5c0f526e3b156f68eaef1fd3dc7ad54 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -32,6 +32,9 @@ class TemplateURL;
class ToolbarView;
#endif
+namespace autofill {
+class PasswordGenerator;
+}
namespace content {
class WebContents;
struct NativeWebKeyboardEvent;
@@ -379,12 +382,15 @@ class BrowserWindow : public BaseWindow {
// Shows the avatar bubble on the window frame off of the avatar button.
virtual void ShowAvatarBubbleFromAvatarButton() = 0;
- // Show bubble for password generation positioned relative to |rect|. |form|
- // is the form that contains the password field that the bubble will be
- // associated with. A stub implementation is provided since this feature is
- // currently not available on mac.
+ // Show bubble for password generation positioned relative to |rect|. The
+ // subclasses implementing this interface do not own the |password_generator|
+ // object which is passed to generate the password. |form| is the form that
+ // contains the password field that the bubble will be associated with. A
+ // stub implementation is provided since this feature is currently not
+ // available on mac.
virtual void ShowPasswordGenerationBubble(
const gfx::Rect& rect,
+ autofill::PasswordGenerator* password_generator,
const webkit::forms::PasswordForm& form) {}
protected:
« no previous file with comments | « chrome/browser/autofill/password_generator_unittest.cc ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698